From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbcFXPgX (ORCPT ); Fri, 24 Jun 2016 11:36:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55550 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbcFXPgV (ORCPT ); Fri, 24 Jun 2016 11:36:21 -0400 Date: Fri, 24 Jun 2016 10:36:18 -0500 From: Josh Poimboeuf To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Borislav Petkov , Nadav Amit , Kees Cook , Brian Gerst , "kernel-hardening@lists.openwall.com" , Linus Torvalds , Jann Horn , Heiko Carstens Subject: Re: [PATCH v4 14/16] x86/dumpstack/64: Handle faults when printing the "Stack:" part of an OOPS Message-ID: <20160624153618.gbl2qzlbkapfbngs@treble> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 24 Jun 2016 15:36:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2016 at 09:23:09PM -0700, Andy Lutomirski wrote: > If we overflow the stack into a guard page, we'll recursively fault > when trying to dump the contents of the guard page. Use > probe_kernel_address so we can recover if this happens. > > Signed-off-by: Andy Lutomirski Reviewed-by: Josh Poimboeuf -- Josh