From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751943AbcFXSZX (ORCPT ); Fri, 24 Jun 2016 14:25:23 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:51906 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbcFXSZU (ORCPT ); Fri, 24 Jun 2016 14:25:20 -0400 Date: Fri, 24 Jun 2016 12:25:15 -0600 From: Jason Gunthorpe To: Ed Swierk Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, jarkko.sakkinen@linux.intel.com, stefanb@us.ibm.com Subject: Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors Message-ID: <20160624182515.GC14506@obsidianresearch.com> References: <1466474042-110773-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-1-git-send-email-eswierk@skyportsystems.com> <1466557831-113440-2-git-send-email-eswierk@skyportsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466557831-113440-2-git-send-email-eswierk@skyportsystems.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > expected = be32_to_cpu(*(__be32 *) (buf + 2)); > if (expected > count) { > + dev_err(chip->pdev, "Response too long (wanted %zd, got %d)\n", > + count, expected); This all needs to be rebased on Jarkko's tree I guess, chip->pdev is gone now. http://git.infradead.org/users/jjs/linux-tpmdd.git/shortlog/refs/heads/master Jarkko, did you miss a pull request for 4.7 or something? This is 4 month old stuff??? Jason