From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751232AbcFYFWm (ORCPT ); Sat, 25 Jun 2016 01:22:42 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33099 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002AbcFYFWk (ORCPT ); Sat, 25 Jun 2016 01:22:40 -0400 Date: Sat, 25 Jun 2016 14:22:37 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Andrew Morton , Tejun Heo , Jan Kara , Calvin Owens , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH] printk: introduce should_ignore_loglevel() Message-ID: <20160625052237.GA580@swordfish> References: <20160623163302.761-1-sergey.senozhatsky@gmail.com> <20160624160533.GI29718@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160624160533.GI29718@pathway.suse.cz> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (06/24/16 18:05), Petr Mladek wrote: [..] > > +static bool should_ignore_loglevel(int level) > > +{ > > + return (level >= console_loglevel && !ignore_loglevel); > > The patch looks fine. It is nice optimization. > > I was just quite confused by the name of this function. A function > called should_ignore_loglevel() should not return false when > ignore_loglevel variable is true. > > I would call it ignore_message() or ignore_message_on_console() or so. Hello Petr, you are right. I was thinking about s/should_ignore_loglevel/suppress_message/g or.... s/should_ignore_loglevel/suppress_message_by_level/g s/should_ignore_loglevel/suppress_message_printing/g suppress_message_printing() is probably fine. will it work for you guys? -ss