From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751357AbcFYHsJ (ORCPT ); Sat, 25 Jun 2016 03:48:09 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47463 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751081AbcFYHsF (ORCPT ); Sat, 25 Jun 2016 03:48:05 -0400 Date: Sat, 25 Jun 2016 09:47:53 +0200 From: Maxime Ripard To: luoyi.ly@gmail.com Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH V3] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board Message-ID: <20160625074753.GF4000@lukather> References: <20160622095723.GU26668@lukather> <20160624061134.9500-1-luoyi.ly@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XStn23h1fwudRqtG" Content-Disposition: inline In-Reply-To: <20160624061134.9500-1-luoyi.ly@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XStn23h1fwudRqtG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Thanks for sending a new version. However, it's usually done in a new thread, not as a reply to a previous mail. If you're not using it, git send-email does all the magic for you. On Fri, Jun 24, 2016 at 02:11:34PM +0800, luoyi.ly@gmail.com wrote: > From: Luo Yi >=20 > Add support for the Bananapi M1 Plus A20 development board from > sinovoip.com.cn . This board is nearly a clone of the Lemaker's > Bananapro, but differ with the wlan chipset connection and i2s pinout. > And I also enable the integrated audio codec on default. >=20 > Signed-off-by: Luo Yi > --- Having a changelog of all the changes you made here (right after ---) would be great. > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 230 +++++++++++++++++= ++++++ > 2 files changed, 231 insertions(+) > create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts >=20 > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index e06a5ab..fde407f 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -685,6 +685,7 @@ dtb-$(CONFIG_MACH_SUN6I) +=3D \ > sun6i-a31s-yones-toptech-bs1078-v2.dtb > dtb-$(CONFIG_MACH_SUN7I) +=3D \ > sun7i-a20-bananapi.dtb \ > + sun7i-a20-bananapi-m1-plus.dtb \ > sun7i-a20-bananapro.dtb \ > sun7i-a20-cubieboard2.dtb \ > sun7i-a20-cubietruck.dtb \ > diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/= boot/dts/sun7i-a20-bananapi-m1-plus.dts > new file mode 100644 > index 0000000..6efc9aa > --- /dev/null > +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts > @@ -0,0 +1,230 @@ > +/* > + * Copyright 2016 Luo Yi > + * > + * Thanks to the original work by Hans de Goede > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +/dts-v1/; > +#include "sun7i-a20.dtsi" > +#include "sunxi-common-regulators.dtsi" > +#include > +#include > + > +/ { > + model =3D "Banana Pi BPI-M1-Plus"; > + compatible =3D "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20"; > + > + aliases { > + serial0 =3D &uart0; > + }; > + > + chosen { > + stdout-path =3D "serial0:115200n8"; > + }; > + > + leds { > + compatible =3D "gpio-leds"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&led_pins_bananapi>; > + > + green { > + label =3D "bananapi-m1-plus:green:usr"; > + gpios =3D <&pio 7 24 GPIO_ACTIVE_HIGH>; > + }; > + > + red { > + label =3D "bananapi-m1-plus:red:usr"; > + gpios =3D <&pio 7 25 GPIO_ACTIVE_HIGH>; > + linux,default-trigger =3D "default-on"; As Chen-Yu already told you, we don't enforce any trigger by default. > + }; > + > + }; > + > + mmc3_pwrseq: mmc3_pwrseq { > + compatible =3D "mmc-pwrseq-simple"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mmc3_pwrseq_pin_bananapim1plus>; > + reset-gpios =3D <&pio 7 22 GPIO_ACTIVE_LOW>; /* PH22 WL-PMU-EN */ > + }; > + > + reg_gmac_3v3: gmac-3v3 { > + compatible =3D "regulator-fixed"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&gmac_power_pin_bananapi>; > + regulator-name =3D "gmac-3v3"; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + startup-delay-us =3D <100000>; > + enable-active-high; > + gpio =3D <&pio 7 23 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > +&ahci { > + status =3D "okay"; > +}; > + > +&codec { > + status =3D "okay"; > +}; > + > +&ehci0 { > + status =3D "okay"; > +}; > + > +&ehci1 { > + status =3D "okay"; > +}; > + > +&gmac { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&gmac_pins_rgmii_a>; > + phy =3D <&phy1>; > + phy-mode =3D "rgmii"; > + phy-supply =3D <®_gmac_3v3>; > + status =3D "okay"; > + > + phy1: ethernet-phy@1 { > + reg =3D <1>; > + }; > +}; > + > +&i2c0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c0_pins_a>; > + status =3D "okay"; > + > + axp209: pmic@34 { > + compatible =3D "x-powers,axp209"; > + reg =3D <0x34>; > + interrupt-parent =3D <&nmi_intc>; > + interrupts =3D <0 IRQ_TYPE_LEVEL_LOW>; > + > + interrupt-controller; > + #interrupt-cells =3D <1>; What's the point of adding the PMIC if you're not adding any of its drivers? > + }; > +}; > + > +&ir0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&ir0_rx_pins_a>; > + status =3D "okay"; > +}; > + > +&mmc0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mmc0_pins_a>, <&mmc0_cd_pin_bananapi>; > + vmmc-supply =3D <®_vcc3v3>; > + bus-width =3D <4>; > + cd-gpios =3D <&pio 7 10 GPIO_ACTIVE_HIGH>; /* PH10 */ > + cd-inverted; > + status =3D "okay"; > +}; > + > +&mmc3 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mmc3_pins_a>; > + vmmc-supply =3D <®_vcc3v3>; > + mmc-pwrseq =3D <&mmc3_pwrseq>; > + bus-width =3D <4>; > + non-removable; > + enable-sdio-wakeup; > + status =3D "okay"; > + > + brcmf: bcrmf@1 { > + reg =3D <1>; > + compatible =3D "brcm,bcm4329-fmac"; > + interrupt-parent =3D <&pio>; > + interrupts =3D <7 15 IRQ_TYPE_LEVEL_LOW>; > + interrupt-names =3D "host-wake"; > + }; > +}; > + > +&mmc3_pins_a { > + /* AP6210 requires pull-up */ > + allwinner,pull =3D ; > +}; > + > +&ohci0 { > + status =3D "okay"; > +}; > + > +&ohci1 { > + status =3D "okay"; > +}; > + > +&pio { > + gmac_power_pin_bananapi: gmac_power_pin@0 { > + allwinner,pins =3D "PH23"; > + allwinner,function =3D "gpio_out"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + > + led_pins_bananapi: led_pins@0 { > + allwinner,pins =3D "PH24", "PG2"; > + allwinner,function =3D "gpio_out"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + > + mmc0_cd_pin_bananapi: mmc0_cd_pin@0 { > + allwinner,pins =3D "PH10"; > + allwinner,function =3D "gpio_in"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + > + mmc3_pwrseq_pin_bananapim1plus: mmc3_pwrseq_pin@0 { > + allwinner,pins =3D "PH22"; > + allwinner,function =3D "gpio_out"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > +}; > + > +&uart0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&uart0_pins_a>; > + status =3D "okay"; > +}; > --=20 > 2.9.0 >=20 It looks good otherwise. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --XStn23h1fwudRqtG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXbjcpAAoJEBx+YmzsjxAgdFQP/2FtZJiFIM+4wRkloCwzyxZf eYl1fR2wjl5c0of+gbdniRk5qlFqFX6tnnDEHtMmlsB659t987e8uBmPCXuW+QPA t2gA65xThvur3XMQGddt5BzHHaCLqMqIWTi1tUFd/Dksv8qUw3jDeJWxdNahJsKh SFBMgZk1bzvktwdeT6D/DNly8E2oXeuekIK/I8T6magQWWKkbgxOnJK6ANDFFmWI 6fNFp3lGfChEuQdx3kAcUR265BYQp3eJo/aXEVF6oodPX77jD11Yfj0WEy29nxhI Ogl9MfLEuzYASLd3EtR0JafN5N2qnnM/P3XiveX/jzMKuu8odGLN0DGS/0pzi5KB yX30B22NMbsuFf8FgcsC8N2jhPDm6qLMoUKOn3bQolixQcWGARGZNH47N464hA5L CaSKrT3yHktcjudwjO3a2kdsNQEUfNAdMdC0lMDQ/toTpR/FCHqH6yXaNaHv6Pjm eQSNR6/pqyz73lqu5Nhjo8FmsIjEEfg85SVsSkDSIjb8A58hT07/FqPX6sJY6h8A bo++XGKZ0aupqo7mDXcuPQMktHAoH91psubT5SPwExegtkdMo/4AL4ECeEK86W2q pqUnPvbVoUfTfjPRZi3O5JseyXzHgmW3fsL82+zsvP9OMxkg0Zv0M25hqCefxD29 7ODVJX6nVSfJJNnxjGQ7 =LETi -----END PGP SIGNATURE----- --XStn23h1fwudRqtG--