From: Greg KH <gregkh@linuxfoundation.org>
To: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: stefan@agner.ch, shawnguo@kernel.org, kernel@pengutronix.de,
mturquette@baylibre.com, sboyd@codeaurora.org, jslaby@suse.com,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/8] tty: serial: fsl_lpuart: consider TX FIFO too in tx_empty
Date: Sat, 25 Jun 2016 14:26:00 -0700 [thread overview]
Message-ID: <20160625212600.GA28726@kroah.com> (raw)
In-Reply-To: <20160609151039.20817-2-bhuvanchandra.dv@toradex.com>
On Thu, Jun 09, 2016 at 08:40:32PM +0530, Bhuvanchandra DV wrote:
> From: Stefan Agner <stefan@agner.ch>
>
> Currently the tx_empty callback only considers the Transmit Complete
> Flag (TC). The reference manual is not quite clear if the TC flag
> covers the TX FIFO too. Debug prints on real hardware have shown that
> from time to time the TC flag is asserted (indicating Transmitter
> idle) while there are still data in the TX FIFO. Hence, in this case
> the serial core will call the shutdown callback even though there are
> data remaining in the TX FIFO buffers.
>
> Avoid early shutdowns by considering the TX FIFO empty flag too. Also
> avoid theoretical race conditions between DMA and the driver by
> checking whether the TX DMA is in progress too.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> drivers/tty/serial/fsl_lpuart.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
Why are you not signing off on patches that are flowing through you?
Please fix this up and resend the series, after breaking up the clock
change as asked.
thanks,
greg k-h
next prev parent reply other threads:[~2016-06-25 21:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 15:10 [PATCH 0/8] Improve Rx/Tx DMA implementation Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 1/8] tty: serial: fsl_lpuart: consider TX FIFO too in tx_empty Bhuvanchandra DV
2016-06-25 21:26 ` Greg KH [this message]
2016-06-28 3:54 ` Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume Bhuvanchandra DV
2016-06-11 14:03 ` Shawn Guo
2016-06-14 0:18 ` Bhhuvanchandra DV
2016-06-14 2:42 ` Stefan Agner
2016-06-21 0:11 ` Stephen Boyd
2016-06-09 15:10 ` [PATCH 3/8] tty: serial: fsl_lpuart: fix clearing of receive flag Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 4/8] tty: serial: fsl_lpuart: Fix broken 8m/s1 support Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 5/8] tty: serial: fsl-lpuart: Use cyclic DMA for Rx Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 6/8] tty: serial: fsl-lpuart: Use scatter/gather DMA for Tx Drop PIO to DMA switching and use scatter/gather DMA for Tx path to improve performance Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 7/8] tty: serial: fsl-lpuart: Update suspend/resume for DMA mode Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 8/8] tty: serial: fsl_lpuart: Add support for RS-485 Bhuvanchandra DV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160625212600.GA28726@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhuvanchandra.dv@toradex.com \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).