From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751952AbcFZRGQ (ORCPT ); Sun, 26 Jun 2016 13:06:16 -0400 Received: from mail.kernel.org ([198.145.29.136]:52146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265AbcFZRGP (ORCPT ); Sun, 26 Jun 2016 13:06:15 -0400 Date: Sun, 26 Jun 2016 14:06:09 -0300 From: Arnaldo Carvalho de Melo To: "Wangnan (F)" Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Marc Kleine-Budde Subject: Re: [PATCH 1/2] perf data convert: Include config.h header Message-ID: <20160626170609.GB3324@kernel.org> References: <1466772025-17471-1-git-send-email-jolsa@kernel.org> <576DDE60.6060208@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <576DDE60.6060208@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Jun 25, 2016 at 09:29:04AM +0800, Wangnan (F) escreveu: > You can add: > > Fixes: 41840d211c51 ("perf config: Move config declarations from > util/cache.h to util/config.h") Yeah, I'll do that, thanks for pointing it out! - Arnaldo > Thank you. > > On 2016/6/24 20:40, Jiri Olsa wrote: > > otherwise some compiler might scream: > > > > $ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1 > > BUILD: Doing 'make -j4' parallel build > > CC util/data-convert-bt.o > > util/data-convert-bt.c: In function ‘convert__config’: > > util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration] > > c->queue_size = perf_config_u64(var, value); > > ... > > > > Link: http://lkml.kernel.org/n/tip-t9dyx71w49dy5tacpdzr5b2p@git.kernel.org > > Signed-off-by: Jiri Olsa > > --- > > tools/perf/util/data-convert-bt.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c > > index 9f53020c3269..5186bb1168af 100644 > > --- a/tools/perf/util/data-convert-bt.c > > +++ b/tools/perf/util/data-convert-bt.c > > @@ -26,6 +26,7 @@ > > #include "evlist.h" > > #include "evsel.h" > > #include "machine.h" > > +#include "config.h" > > #define pr_N(n, fmt, ...) \ > > eprintf(n, debug_data_convert, fmt, ##__VA_ARGS__) >