From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: f.fainelli@gmail.com, robh+dt@kernel.org, frowand.list@gmail.com,
david.daney@cavium.com, andrew@lunn.ch,
sergei.shtylyov@cogentembedded.com,
ben.hutchings@codethink.co.uk, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] of_mdio: select fixed phy support unconditionally
Date: Tue, 28 Jun 2016 05:43:42 -0400 (EDT) [thread overview]
Message-ID: <20160628.054342.1681185612913979373.davem@davemloft.net> (raw)
In-Reply-To: <20160624092450.1507991-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 24 Jun 2016 11:24:08 +0200
> Calling the fixed-phy functions when CONFIG_FIXED_PHY=m as a previous
> change tried cannot work if the caller is in built-in code:
>
> drivers/of/built-in.o: In function `of_phy_register_fixed_link':
> of_reserved_mem.c:(.text+0x85e0): undefined reference to `fixed_phy_register'
>
> Making of_mdio depend on 'FIXED_PHY || !FIXED_PHY' would solve this
> dependency by enforcing that OF_MDIO itself becomes a loadable module
> when FIXED_PHY=y, but that creates a different dependency as it
> breaks any built-in ethernet driver that uses of_mdio.
>
> Making FIXED_PHY a bool option also cannot work, since it depends on
> PHYLIB, which again is tristate.
>
> This version now uses 'select FIXED_PHY' to ensure that the fixed-phy
> portion of of_mdio is not optional. The main downside of this is
> a small increase in code size for cases that do not need fixed phy
> support, but it should avoid all of the link-time problems.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: d1bd330a229f ("of_mdio: Enable fixed PHY support if driver is a module")
Applied to net-next, thanks Arnd.
In the future, please be explicit about what tree a patch is
targetting by specifying it in your Subject line, as:
[PATCH net-next] ...
or similar.
Thanks.
next prev parent reply other threads:[~2016-06-28 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 9:24 [PATCH] of_mdio: select fixed phy support unconditionally Arnd Bergmann
2016-06-25 17:55 ` Randy Dunlap
2016-06-28 9:43 ` David Miller [this message]
2016-06-28 9:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628.054342.1681185612913979373.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=ben.hutchings@codethink.co.uk \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).