From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752517AbcF1NBp (ORCPT ); Tue, 28 Jun 2016 09:01:45 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:56636 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752256AbcF1NBo (ORCPT ); Tue, 28 Jun 2016 09:01:44 -0400 Date: Tue, 28 Jun 2016 09:01:12 -0400 (EDT) Message-Id: <20160628.090112.1438085992622018555.davem@davemloft.net> To: joe@perches.com Cc: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org Subject: Re: [PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked From: David Miller In-Reply-To: <3dcddfef3b9ac0eceb2869d9e95ae857b509fabe.1466793022.git.joe@perches.com> References: <20160624085752.GB1939@salvia> <3dcddfef3b9ac0eceb2869d9e95ae857b509fabe.1466793022.git.joe@perches.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 28 Jun 2016 06:01:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Fri, 24 Jun 2016 11:32:26 -0700 > There are code duplications of a masked ethernet address comparison here > so make it a separate function instead. > > Miscellanea: > > o Neaten alignment of FWINV macro uses to make it clearer for the reader > > Signed-off-by: Joe Perches Pablo feel free to take this: Acked-by: David S. Miller