From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752006AbcF1GtA (ORCPT ); Tue, 28 Jun 2016 02:49:00 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:34299 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbcF1Gs6 (ORCPT ); Tue, 28 Jun 2016 02:48:58 -0400 Date: Tue, 28 Jun 2016 07:49:48 +0100 From: Lee Jones To: Keerthy Cc: dmitry.torokhov@gmail.com, linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org, tony@atomide.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 03/10] input: tps65218-pwrbutton: Add platform_device_id table Message-ID: <20160628064948.GB6720@dell> References: <1467093980-11458-1-git-send-email-j-keerthy@ti.com> <1467093980-11458-4-git-send-email-j-keerthy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1467093980-11458-4-git-send-email-j-keerthy@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jun 2016, Keerthy wrote: > platform_device_id table is needed for adding the tps65218-pwrbutton > module to the mfd_cell array. > > Signed-off-by: Keerthy > --- > drivers/input/misc/tps65218-pwrbutton.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/input/misc/tps65218-pwrbutton.c b/drivers/input/misc/tps65218-pwrbutton.c > index 2bba8de..a0cb7d2 100644 > --- a/drivers/input/misc/tps65218-pwrbutton.c > +++ b/drivers/input/misc/tps65218-pwrbutton.c > @@ -113,12 +113,19 @@ static const struct of_device_id of_tps65218_pwr_match[] = { > }; > MODULE_DEVICE_TABLE(of, of_tps65218_pwr_match); > > +static const struct platform_device_id tps65218_pwrbtn_id_table[] = { > + { "tps65218-pwrbutton", }, > + { /* sentinel */ } > +} Missing ';'. Did you build test this? > +MODULE_DEVICE_TABLE(platform, tps65218_pwrbtn_id_table); > + > static struct platform_driver tps65218_pwron_driver = { > .probe = tps65218_pwron_probe, > .driver = { > .name = "tps65218_pwrbutton", > .of_match_table = of_tps65218_pwr_match, > }, > + .id_table = tps65218_pwrbtn_id_table, > }; > module_platform_driver(tps65218_pwron_driver); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog