From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752051AbcF1Cdi (ORCPT ); Mon, 27 Jun 2016 22:33:38 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:34407 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbcF1Cdh convert rfc822-to-8bit (ORCPT ); Mon, 27 Jun 2016 22:33:37 -0400 Date: Tue, 28 Jun 2016 10:29:27 +0800 From: Jisheng Zhang To: Srinivas Pandruvada , , , CC: , Subject: Re: [PATCH v2 3/3] intel_pstate: Declare pid_params/pstate_funcs/hwp_active __read_mostly Message-ID: <20160628102927.4d74fb2c@xhacker> In-Reply-To: <1467048594.8970.81.camel@linux.intel.com> References: <1467022038-924-1-git-send-email-jszhang@marvell.com> <1467022038-924-4-git-send-email-jszhang@marvell.com> <1467048594.8970.81.camel@linux.intel.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-28_01:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606280022 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Rafael, On Mon, 27 Jun 2016 10:29:54 -0700 Srinivas Pandruvada wrote: > On Mon, 2016-06-27 at 18:07 +0800, Jisheng Zhang wrote: > > pid_params is written once by copy_pid_params() during > > initialization, > > and thereafter is mostly read by hot path intel_pstate_update_util(). > > The read of pid_params gets more after commit a4675fbc4a7a ("cpufreq: > > intel_pstate: Replace timers with utilization update callbacks") > > > > pstate_funcs is written once by copy_cpu_funcs() during > > initialization, > > and thereafter is mostly read by hot path intel_pstate_update_util() > > > > hwp_active is written to once during initialization and thereafter is > > mostly read by hot path intel_pstate_update_util(). > > > > The fact that they are mostly read and not written to makes them > > candidates for __read_mostly declarations. > > > > Signed-off-by: Jisheng Zhang > Acked-by: Srinivas Pandruvada oops, I missed Viresh's Ack in this patch, so can you please add the missing Acked-by: Viresh Kumar Sorry for inconvenience, Jisheng > > --- > >  drivers/cpufreq/intel_pstate.c | 6 +++--- > >  1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/cpufreq/intel_pstate.c > > b/drivers/cpufreq/intel_pstate.c > > index 861bcba..2eda50d 100644 > > --- a/drivers/cpufreq/intel_pstate.c > > +++ b/drivers/cpufreq/intel_pstate.c > > @@ -281,9 +281,9 @@ struct cpu_defaults { > >  static inline int32_t get_target_pstate_use_performance(struct > > cpudata *cpu); > >  static inline int32_t get_target_pstate_use_cpu_load(struct cpudata > > *cpu); > >   > > -static struct pstate_adjust_policy pid_params; > > -static struct pstate_funcs pstate_funcs; > > -static int hwp_active; > > +static struct pstate_adjust_policy pid_params __read_mostly; > > +static struct pstate_funcs pstate_funcs __read_mostly; > > +static int hwp_active __read_mostly; > >   > >  #ifdef CONFIG_ACPI > >  static bool acpi_ppc;