From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbcF1LSQ (ORCPT ); Tue, 28 Jun 2016 07:18:16 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37700 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbcF1LSO (ORCPT ); Tue, 28 Jun 2016 07:18:14 -0400 Date: Tue, 28 Jun 2016 12:13:43 +0100 From: Lee Jones To: Mark Brown Cc: Keerthy , tony@atomide.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, t-kristo@ti.com, russ.dill@ti.com, Dave Gerlach Subject: Re: [PATCH v2 5/5] regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs Message-ID: <20160628111343.GC17585@dell> References: <1466756892-17015-1-git-send-email-j-keerthy@ti.com> <1466756892-17015-5-git-send-email-j-keerthy@ti.com> <20160627165930.GC17217@sirena.org.uk> <20160628111206.GB17585@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160628111206.GB17585@dell> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Jun 2016, Lee Jones wrote: > On Mon, 27 Jun 2016, Mark Brown wrote: > > > On Fri, Jun 24, 2016 at 01:58:11PM +0530, Keerthy wrote: > > > From: Tero Kristo > > > > > > Some versions of tps65218 do not seem to support poweroff modes properly > > > if DCDC3 regulator is shut-down. Thus, keep it enabled even during > > > poweroff if the version info matches the broken silicon revision. > > > > This is fine but depends on the MFD bit so needs to wait for that to be > > reviewed. > > I think it's fine for you to take this. Tell a lie. I just saw the struct member added in the other patch. Do you want to take the set? If so, I'll just Ack my bit. For the MFD changes in this patch: Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog