From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752425AbcF1PB5 (ORCPT ); Tue, 28 Jun 2016 11:01:57 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:35699 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbcF1PBz (ORCPT ); Tue, 28 Jun 2016 11:01:55 -0400 Date: Tue, 28 Jun 2016 16:02:45 +0100 From: Lee Jones To: SF Markus Elfring Cc: Tony Lindgren , linux-omap@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/6] mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child() Message-ID: <20160628150245.GI24982@dell> References: <566ABCD9.1060404@users.sourceforge.net> <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1> <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net> <20160608111442.GB14888@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Jun 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 26 Jun 2016 12:25:36 +0200 Please use `git send-email` when sending patches to the list. > The platform_device_put() function was called in one case by the > add_numbered_child() function during error handling even if the passed > variable "pdev" contained a null pointer. > Return directly in this case. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/mfd/twl-core.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Applied though, thanks. > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > index 831696e..9458c6d 100644 > --- a/drivers/mfd/twl-core.c > +++ b/drivers/mfd/twl-core.c > @@ -622,11 +622,8 @@ add_numbered_child(unsigned mod_no, const char *name, int num, > twl = &twl_priv->twl_modules[sid]; > > pdev = platform_device_alloc(name, num); > - if (!pdev) { > - dev_dbg(&twl->client->dev, "can't alloc dev\n"); > - status = -ENOMEM; > - goto err; > - } > + if (!pdev) > + return ERR_PTR(-ENOMEM); > > pdev->dev.parent = &twl->client->dev; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog