From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752617AbcF1PHO (ORCPT ); Tue, 28 Jun 2016 11:07:14 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36950 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbcF1PHL (ORCPT ); Tue, 28 Jun 2016 11:07:11 -0400 Date: Tue, 28 Jun 2016 16:07:56 +0100 From: Lee Jones To: SF Markus Elfring Cc: Tony Lindgren , linux-omap@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 5/6] mfd: smsc-ece1099: Delete an unnecessary variable initialisation in smsc_i2c_probe() Message-ID: <20160628150756.GM24982@dell> References: <566ABCD9.1060404@users.sourceforge.net> <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1> <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net> <20160608111442.GB14888@dell> <1b29f010-5617-3862-23f5-42a5e6a1bc81@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1b29f010-5617-3862-23f5-42a5e6a1bc81@users.sourceforge.net> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Jun 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 26 Jun 2016 14:14:54 +0200 > > The variable "ret" will be set to an appropriate value a bit later. > Thus omit the explicit initialisation at the beginning. > > Signed-off-by: Markus Elfring > --- > drivers/mfd/smsc-ece1099.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c > index 7f89e89..2aaf89f 100644 > --- a/drivers/mfd/smsc-ece1099.c > +++ b/drivers/mfd/smsc-ece1099.c > @@ -36,7 +36,7 @@ static int smsc_i2c_probe(struct i2c_client *i2c, > { > struct smsc *smsc; > int devid, rev, venid_l, venid_h; > - int ret = 0; > + int ret; > > smsc = devm_kzalloc(&i2c->dev, sizeof(struct smsc), > GFP_KERNEL); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog