From: Darren Hart <dvhart@infradead.org>
To: Jonathan Woithe <jwoithe@just42.net>
Cc: Micha?? K??pie?? <kernel@kempniu.pl>,
Jan-Marek Glogowski <glogow@fbihome.de>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] fujitsu-laptop: Debugging cleanup
Date: Tue, 28 Jun 2016 10:49:48 -0700 [thread overview]
Message-ID: <20160628174948.GE3837@f23x64.localdomain> (raw)
In-Reply-To: <20160623103535.GA18242@marvin.atrad.com.au>
On Thu, Jun 23, 2016 at 08:05:35PM +0930, Jonathan Woithe wrote:
> On Thu, Jun 23, 2016 at 12:02:46PM +0200, Micha?? K??pie?? wrote:
> > vdbg_printk() was introduced by 20b9373, which is the same commit that
> > adds FUJ02E3 support, so it has been the way it is now from the start.
> > This patch series attempts to tidy things up a bit.
> >
> > drivers/platform/x86/fujitsu-laptop.c | 12 +-----------
> > 1 file changed, 1 insertion(+), 11 deletions(-)
>
> Yes, good idea. Both patches look good to me. I would like to note in
> passing that the removal of the unused defines in the second patch was in
> fact suggested as part of a broader cleanup series by Alan Jenkins an
> embarassingly long time ago. For various reasons I didn't get a chance to
> review and apply his patch series at the time. It is my aim to rectify this
> soon, but in the meantime this two patch series is good to go in. Thanks
> for the submission.
>
> Acked-by: Jonathan Woithe <jwoithe@just42.net>
Queued to testing for 4.8.
>
> Regards
> jonathan
>
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2016-06-28 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160616234630.GB4764@marvin.atrad.com.au>
2016-06-23 10:02 ` [PATCH 0/2] fujitsu-laptop: Debugging cleanup Michał Kępień
2016-06-23 10:02 ` [PATCH 1/2] fujitsu-laptop: Use module name in debug messages Michał Kępień
2016-06-23 10:02 ` [PATCH 2/2] fujitsu-laptop: Remove unused macros Michał Kępień
2016-06-23 10:35 ` [PATCH 0/2] fujitsu-laptop: Debugging cleanup Jonathan Woithe
2016-06-28 17:49 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628174948.GE3837@f23x64.localdomain \
--to=dvhart@infradead.org \
--cc=glogow@fbihome.de \
--cc=jwoithe@just42.net \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).