From: Arnd Bergmann <arnd@arndb.de>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Hans Verkuil <hans.verkuil@cisco.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kamil Debski <kamil@wypas.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] [media] cec: add RC_CORE dependency
Date: Wed, 29 Jun 2016 16:26:36 +0200 [thread overview]
Message-ID: <20160629142749.4125434-3-arnd@arndb.de> (raw)
In-Reply-To: <20160629142749.4125434-1-arnd@arndb.de>
We cannot build the cec driver when the RC core is a module
and cec is built-in:
drivers/staging/built-in.o: In function `cec_allocate_adapter':
:(.text+0x134): undefined reference to `rc_allocate_device'
drivers/staging/built-in.o: In function `cec_register_adapter':
:(.text+0x304): undefined reference to `rc_register_device'
This adds an explicit dependency to avoid this case. We still
allow building when CONFIG_RC_CORE is disabled completely,
as the driver has checks for this case itself.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/media/cec/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/cec/Kconfig b/drivers/staging/media/cec/Kconfig
index cd523590ea6f..b83b4d83946d 100644
--- a/drivers/staging/media/cec/Kconfig
+++ b/drivers/staging/media/cec/Kconfig
@@ -1,6 +1,7 @@
config MEDIA_CEC
tristate "CEC API (EXPERIMENTAL)"
depends on MEDIA_SUPPORT
+ depends on RC_CORE || !RC_CORE
select MEDIA_CEC_EDID
---help---
Enable the CEC API.
--
2.9.0
prev parent reply other threads:[~2016-06-29 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 14:26 [PATCH 1/3] [media] s5p_cec: mark suspend/resume as __maybe_unused Arnd Bergmann
2016-06-29 14:26 ` [PATCH 2/3] [media] cec: add MEDIA_SUPPORT dependency Arnd Bergmann
2016-06-29 14:26 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629142749.4125434-3-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=kamil@wypas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).