From: Mark Brown <broonie@kernel.org>
To: Garlic Tseng <garlic.tseng@mediatek.com>
Cc: tiwai@suse.de, srv_heupstream@mediatek.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
koro.chen@mediatek.com, PC.Liao@mediatek.com,
ir.lian@mediatek.com
Subject: Re: [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation.
Date: Wed, 29 Jun 2016 20:13:22 +0100 [thread overview]
Message-ID: <20160629191322.GT6247@sirena.org.uk> (raw)
In-Reply-To: <1466149440-23889-7-git-send-email-garlic.tseng@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
On Fri, Jun 17, 2016 at 03:43:57PM +0800, Garlic Tseng wrote:
> +static int mt2701_afe_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id,
> + int div)
> +{
Why are we adding a set_clkdiv() operation? I would expect the driver
to be able to figure things out automatically.
> + case DIV_ID_MCLK_TO_BCK:
> + afe_priv->i2s_path[i2s_num].div_mclk_to_bck = div;
> + break;
> + case DIV_ID_BCK_TO_LRCK:
> + afe_priv->i2s_path[i2s_num].div_bck_to_lrck = div;
> + break;
Especially in the case where we're configuring LRCLK, that's trivial
when we know the sample rate which we have to know anyway.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-30 12:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 7:43 [alsa-devel] [PATCH v5 0/9] ASoC: Mediatek: Add support for MT2701 SOC Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 1/9] ASoC: mediatek: Refine mt8173 driver and change config option Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 2/9] ASoC: mediatek: implement mediatek common structure Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 3/9] ASoC: mediatek: let mt8173 use " Garlic Tseng
2016-06-29 19:16 ` Applied "ASoC: mediatek: let mt8173 use mediatek common structure" to the asoc tree Mark Brown
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 4/9] ASoC: mediatek: add documents for mt2701 Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 5/9] ASoC: mediatek: add structure define and clock control for 2701 Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation Garlic Tseng
2016-06-29 19:13 ` Mark Brown [this message]
2016-06-30 13:39 ` Garlic Tseng
2016-07-04 2:28 ` Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string Garlic Tseng
2016-06-29 19:15 ` Mark Brown
2016-06-30 12:55 ` Garlic Tseng
2016-07-01 2:49 ` Garlic Tseng
2016-07-01 16:11 ` Mark Brown
2016-07-02 9:05 ` Chen-Yu Tsai
2016-07-04 1:59 ` Garlic Tseng
2016-06-17 7:43 ` [alsa-devel] [PATCH v5 8/9] ASoC: mediatek: add BT implementation Garlic Tseng
2016-06-17 7:44 ` [alsa-devel] [PATCH v5 9/9] ASoC: mediatek: Add mt2701-cs42448 driver and config option Garlic Tseng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629191322.GT6247@sirena.org.uk \
--to=broonie@kernel.org \
--cc=PC.Liao@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=garlic.tseng@mediatek.com \
--cc=ir.lian@mediatek.com \
--cc=koro.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).