From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932227AbcF3MSd (ORCPT ); Thu, 30 Jun 2016 08:18:33 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58644 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990AbcF3MQF (ORCPT ); Thu, 30 Jun 2016 08:16:05 -0400 Date: Wed, 29 Jun 2016 20:15:00 +0100 From: Mark Brown To: Garlic Tseng Cc: tiwai@suse.de, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, koro.chen@mediatek.com, PC.Liao@mediatek.com, ir.lian@mediatek.com Message-ID: <20160629191500.GU6247@sirena.org.uk> References: <1466149440-23889-1-git-send-email-garlic.tseng@mediatek.com> <1466149440-23889-8-git-send-email-garlic.tseng@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MjBORTcaENZKFEO1" Content-Disposition: inline In-Reply-To: <1466149440-23889-8-git-send-email-garlic.tseng@mediatek.com> X-Cookie: You are always busy. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 137.158.23.105 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --MjBORTcaENZKFEO1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote: > Add supports for 16k (wideband BT) and add a general compatible > string "linux,bt-sco" This will claim that we support 16k on existing systems which we clearly don't. It also seems unwise to advertise multiple rates when we've no way to configure the rates... how does the BT controller figure out what the sample rate is? --MjBORTcaENZKFEO1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXdB4zAAoJECTWi3JdVIfQk0UH/ivAoNRfwnxjiaDNkWMPVJ/+ IMhTGwc4JBqltAFyozsySN0BuihlNlDOtNDOlx4qzPtLjEj3UilN2MKW9gWrUGML V+tfxVIWDQyyy9kP2ho3KS1jiFhyjXTZdVUgOq7APLkFyVtbyH8mJ8Jje6nH0FrK nhij4Kb1uraqzUfd5vWRNOAqu1S/Wr/yvZPWY6xPl9QZW3Xcd/9UVraldXxaI/Rx tYZfrJ3UgQDz6DoeYwxEMo8CeB1+7lewVxNuTzmbD0GgI7KmWB7TSL2Mh3lDACnm J+2Chr1fCC2OY4QmI5gOwvE+EhoXnveVcaV8GaTJbU9fDJ1s/NRnY3sBsY9VTWM= =w44z -----END PGP SIGNATURE----- --MjBORTcaENZKFEO1--