From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751720AbcF2TWi (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Jun 2016 15:22:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35894 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751290AbcF2TWh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Jun 2016 15:22:37 -0400
Date: Wed, 29 Jun 2016 21:22:33 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        Vladimir Davydov <vdavydov@parallels.com>,
        David Rientjes <rientjes@google.com>, linux-mm@kvack.org,
        LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix
Message-ID: <20160629192232.GA19097@redhat.com>
References: <1467201562-6709-1-git-send-email-mhocko@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467201562-6709-1-git-send-email-mhocko@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 29 Jun 2016 19:22:36 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/29, Michal Hocko wrote:
>
> But it seems that further changes I am
> planning in this area will benefit from stable task->mm in this path

Oh, so I hope you will cleanup this later,

> Just pull the task->mm !=
> NULL check inside the function.

OK, but this means it will always return false if the task is a zombie
leader.

I am not really arguing and this is not that bad, but this doesn't look
nice and imo asks for cleanup.

Oleg.