From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751441AbcF3ET6 (ORCPT ); Thu, 30 Jun 2016 00:19:58 -0400 Received: from mga01.intel.com ([192.55.52.88]:26308 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbcF3ET5 (ORCPT ); Thu, 30 Jun 2016 00:19:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,550,1459839600"; d="scan'208";a="997789371" Date: Thu, 30 Jun 2016 09:56:53 +0530 From: Vinod Koul To: Kedareswara rao Appana Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, dan.j.williams@intel.com, appanad@xilinx.com, moritz.fischer@ettus.com, laurent.pinchart@ideasonboard.com, luis@debethencourt.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Punnaiah Choudary Kalluri Subject: Re: [PATCH v11 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support Message-ID: <20160630042653.GM14945@localhost> References: <1465486667-30737-1-git-send-email-appanad@xilinx.com> <1465486667-30737-2-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465486667-30737-2-git-send-email-appanad@xilinx.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2016 at 09:07:47PM +0530, Kedareswara rao Appana wrote: > + dma_set_mask(&pdev->dev, DMA_BIT_MASK(44)); > + dma_cap_set(DMA_SG, zdev->common.cap_mask); > + dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask); > /** > + * struct zynqmp_dma_config - ZYNQMP DMA Configuration structure > + * @ovrfetch: Overfetch status > + * @has_sg: Support scatter gather transfers > + * @ratectrl: Rate control value > + * @src_issue: Out standing transactions on source > + * @src_burst_len: Source burst length > + * @dst_burst_len: Dest burst length > + */ As discussed in other thread as well, this is no-go for memcpy. Please come back after removing this For slave usages use the dma_slave_config -- ~Vinod