From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932098AbcF3HSI (ORCPT ); Thu, 30 Jun 2016 03:18:08 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:33221 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751935AbcF3HSE (ORCPT ); Thu, 30 Jun 2016 03:18:04 -0400 X-AuditID: cbfee68e-f79266d000001428-67-5774c7aab938 Date: Thu, 30 Jun 2016 16:18:02 +0900 From: Andi Shyti To: Chanwoo Choi Cc: Jaehoon Chung , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH v2 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks Message-id: <20160630071802.GB10787@samsunx.samsung> References: <1467032594-7643-1-git-send-email-andi.shyti@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <1467032594-7643-1-git-send-email-andi.shyti@samsung.com> User-Agent: Mutt/1.6.0 (2016-04-01) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsWyRsSkQHfV8ZJwg6+tUhaLfzxnsrj+5Tmr xY1fbawWr18YWvQ/fs1ssenxNVaLjz33WC0u75rDZjHj/D4mi4unXC0Ov2lntfhxppvFYtWu P4wOvB7vb7Sye1zu62XyuL7kE7PHzll32T02repk89i8pN6jb8sqRo/Pm+QCOKK4bFJSczLL Uov07RK4Mn5u/8lWMJO14ubaZqYGxsksXYycHBICJhJHWt+wQdhiEhfurQeyuTiEBFYwSnxa s5YRpujuxTYmiMRSRonN7RNYIJyPjBI/JswAG8UioCrxf/5ksFFsApoSTbd/gNkiAhoSM/9e YQRpYBY4yyzxYOJpIIeDQ1ggSuJLTxRIDS/Qhgftaxkhhs5mlLg+6yorREJQ4sfke2ALmAW0 JNbvPM4EYUtLPPo7gx1kDqeAm8S/Y3UgpqiAssTdZUEgYyQEejkkFkz9zg5xm4DEt8mHWEBq JARkJTYdYIZ4TFLi4IobLBMYxWYhWTYLybJZSJYtYGRexSiaWpBcUJyUXmSkV5yYW1yal66X nJ+7iREYy6f/PevbwXjzgPUhRgEORiUe3hmsJeFCrIllxZW5hxhNga6YyCwlmpwPTBh5JfGG xmZGFqYmpsZG5pZmSuK8CVI/g4UE0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUwtnQf3Huuv31N ZeK64oUdeQFnhcruuouYn9nA23LOw2LbjO/nfkl84btjXpGzw+4hY97TZv0a5rBk1R1LhGf9 KOTOuuNkbPTyaM6vqxd+3Ha/sdND6/xX6btRFdPsj8UZv07R3a4h3CGsv+XbRgkx/cpleRt0 7/Blrf1YPP3qM7HHZhvitv8XVWIpzkg01GIuKk4EACT5NX3gAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsVy+t9jAd1Vx0vCDdZMFbFY/OM5k8X1L89Z LW78amO1eP3C0KL/8Wtmi02Pr7FafOy5x2pxedccNosZ5/cxWVw85Wpx+E07q8WPM90sFqt2 /WF04PV4f6OV3eNyXy+Tx/Uln5g9ds66y+6xaVUnm8fmJfUefVtWMXp83iQXwBHVwGiTkZqY klqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA3SxkkJZYk4pUCgg sbhYSd8O04TQEDddC5jGCF3fkCC4HiMDNJCwhjHj5/afbAUzWSturm1mamCczNLFyMkhIWAi cfdiGxOELSZx4d56ti5GLg4hgaWMEpvbJ7BAOB8ZJX5MmAHWwSKgKvF//mQ2EJtNQFOi6fYP MFtEQENi5t8rjCANzAJnmSUeTDwN5HBwCAtESXzpiQKp4QXa9qB9LSPE0NmMEtdnXWWFSAhK /Jh8D2wBs4CWxPqdx5kgbGmJR39nsIPM4RRwk/h3rA7EFBVQlri7LGgCo8AsJM2zkDTPQtK8 gJF5FaNEakFyQXFSeq5RXmq5XnFibnFpXrpecn7uJkZwungmvYPx8C73Q4wCHIxKPLwH9pWE C7EmlhVX5h5ilOBgVhLh3XgQKMSbklhZlVqUH19UmpNafIjRFBgeE5mlRJPzgaksryTe0NjE zMjSyNzQwsjYXEmc9/H/dWFCAumJJanZqakFqUUwfUwcnFINjLmp2kY5WXMfMaoJbzMS8HGY 8WjNoel3Ix3vi858ozf1ul/6am/FA4sZN6l+9bw7QUjoCW9mb9e3ubbzA6Nf7EhKdXP+bvnR 3mFZj9W6DO8Y7qPBNVte99qqn9Ti0SzkXs/3/vHEVJ4cYy5zlqb37rLn+lw7F4TUzDm3yoPx A7dMvGr5hkpNJZbijERDLeai4kQAJ0aQxi0DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jun 27, 2016 at 10:03:13PM +0900, Andi Shyti wrote: > The CLK_IGNORE_UNUSED flag has to be avoided whenever possible. > Use the CLK_IS_CRITICAL flag instead, which enables the clock line > during boot time. > > While none of the SCLK_SPI need to be alive all the time as that > clock is handled by the SPI driver as a busclk whenever needed. > > Suggested-by: Tomasz Figa > Signed-off-by: Andi Shyti > --- sorry for spamming, please ignore this patch, some more testing has shown that if the SCLK_SPI1 is not kept alive, the device not always works. Thanks and sorry again, Andi