linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Murali Karicheri <m-karicheri2@ti.com>,
	Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>
Subject: [PATCH 06/14] PCI: keystone: make it explicitly non-modular
Date: Sat, 2 Jul 2016 19:13:26 -0400	[thread overview]
Message-ID: <20160702231334.26684-7-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160702231334.26684-1-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

drivers/pci/host/Kconfig:config PCI_KEYSTONE
drivers/pci/host/Kconfig:       bool "TI Keystone PCIe controller"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple instances of modular code usage, so that
when reading the driver there is no doubt it is builtin-only.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Murali Karicheri <m-karicheri2@ti.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/pci/host/pci-keystone.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c
index 6b8301ef21ca..8ba28834d470 100644
--- a/drivers/pci/host/pci-keystone.c
+++ b/drivers/pci/host/pci-keystone.c
@@ -17,7 +17,7 @@
 #include <linux/delay.h>
 #include <linux/interrupt.h>
 #include <linux/irqdomain.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/msi.h>
 #include <linux/of_irq.h>
 #include <linux/of.h>
@@ -360,7 +360,6 @@ static const struct of_device_id ks_pcie_of_match[] = {
 	},
 	{ },
 };
-MODULE_DEVICE_TABLE(of, ks_pcie_of_match);
 
 static int __exit ks_pcie_remove(struct platform_device *pdev)
 {
@@ -439,9 +438,4 @@ static struct platform_driver ks_pcie_driver __refdata = {
 		.of_match_table = of_match_ptr(ks_pcie_of_match),
 	},
 };
-
-module_platform_driver(ks_pcie_driver);
-
-MODULE_AUTHOR("Murali Karicheri <m-karicheri2@ti.com>");
-MODULE_DESCRIPTION("Keystone PCIe host controller driver");
-MODULE_LICENSE("GPL v2");
+builtin_platform_driver(ks_pcie_driver);
-- 
2.8.4

  parent reply	other threads:[~2016-07-02 23:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-02 23:13 [PATCH 00/14] PCI: trivial demodularization of builtin code Paul Gortmaker
2016-07-02 23:13 ` [PATCH 01/14] PCI: armada8k: make it explicitly non-modular Paul Gortmaker
2016-07-02 23:13 ` [PATCH 02/14] PCI: artpec6: " Paul Gortmaker
2016-07-02 23:13 ` [PATCH 03/14] PCI: designware-plat: " Paul Gortmaker
2016-07-04  9:09   ` Joao Pinto
2016-07-02 23:13 ` [PATCH 04/14] PCI: generic: " Paul Gortmaker
2016-07-04 17:37   ` Will Deacon
2016-07-05 20:19     ` David Daney
2016-07-06  4:25       ` Jayachandran C
2016-07-06 17:02   ` Will Deacon
2016-07-06 17:39     ` Paul Gortmaker
2016-07-02 23:13 ` [PATCH 05/14] PCI: hisi: " Paul Gortmaker
2016-07-02 23:13 ` Paul Gortmaker [this message]
2016-07-06 19:28   ` [PATCH 06/14] PCI: keystone: " Murali Karicheri
2016-07-02 23:13 ` [PATCH 07/14] PCI: layerscape: " Paul Gortmaker
2016-07-02 23:13 ` [PATCH 08/14] PCI: mvebu: " Paul Gortmaker
2016-07-02 23:13 ` [PATCH 09/14] PCI: rcar: " Paul Gortmaker
2016-07-02 23:13 ` [PATCH 10/14] PCI: rcar-gen2: " Paul Gortmaker
2016-07-02 23:13 ` [PATCH 11/14] PCI: tegra: " Paul Gortmaker
2016-07-02 23:13 ` [PATCH 12/14] PCI: thunder-ecam: " Paul Gortmaker
2016-07-02 23:13 ` [PATCH 13/14] PCI: thunder-pem: " Paul Gortmaker
2016-07-02 23:13 ` [PATCH 14/14] PCI: xgene: " Paul Gortmaker
     [not found]   ` <CACoXjc=Tw2a_oCvxTmZY+7jeyyb9XvLF1yWx9FEPWekPBaAw1g@mail.gmail.com>
2016-07-07 22:42     ` Duc Dang
2016-07-09 23:15       ` Paul Gortmaker
2016-07-11 17:12         ` Duc Dang
2016-07-22 21:52 ` [PATCH 00/14] PCI: trivial demodularization of builtin code Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160702231334.26684-7-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).