linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: <linux-kernel@vger.kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Kukjin Kim <kgene@kernel.org>,
	<linux-samsung-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular
Date: Tue, 5 Jul 2016 09:32:16 -0400	[thread overview]
Message-ID: <20160705133216.GC26134@windriver.com> (raw)
In-Reply-To: <577B782E.9090203@samsung.com>

[Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular] On 05/07/2016 (Tue 11:04) Krzysztof Kozlowski wrote:

> On 07/04/2016 11:12 PM, Paul Gortmaker wrote:
> > The Kconfig currently controlling compilation of this code is:
> > 
> > arch/arm/mach-exynos/Kconfig:menuconfig ARCH_EXYNOS
> > arch/arm/mach-exynos/Kconfig:   bool "Samsung EXYNOS" if ARCH_MULTI_V7
> > 
> > ...meaning that it currently is not being built as a module by anyone.
> > 
> > Lets remove the couple traces of modularity so that when reading the
> > driver there is no doubt it is builtin-only.
> > 
> > Lets remove the modular code that is essentially orphaned, so that
> > when reading the driver there is no doubt it is builtin-only.
> > 

[...]

> > -MODULE_DESCRIPTION("Exynos Audio Subsystem Clock Controller");
> > -MODULE_LICENSE("GPL v2");
> > -MODULE_ALIAS("platform:exynos-audss-clk");
> 
> Why not removing .remove() callback as well?
> 
> I don't find sysfs unbind hook useful except testing the exit paths...
> which in that case do not exist anymore (there is no "modprobe -r" for
> it anyway).

Yes, I normally delete the .remove callbacks as indicated in the 0/10,
but somehow I overlooked this one.   Thanks for spotting it.  I'll
delete it and disable the sysfs bind in v2.

Paul.
--

> 
> Best regards,
> Krzysztof
> 

  reply	other threads:[~2016-07-05 13:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 21:12 [PATCH 00/10] clk: fix/remove module usage in non-modular code Paul Gortmaker
2016-07-04 21:12 ` [PATCH 01/10] clk: meson8b: make it explicitly non-modular Paul Gortmaker
2016-07-06 22:21   ` Michael Turquette
2016-07-04 21:12 ` [PATCH 02/10] clk: meson: make gxbb " Paul Gortmaker
2016-07-06 22:21   ` Michael Turquette
2016-07-04 21:12 ` [PATCH 03/10] clk: mvebu: make cp110-system-controller " Paul Gortmaker
2016-11-04 20:32   ` Stephen Boyd
2016-07-04 21:12 ` [PATCH 04/10] clk: mvebu: make ap806-system-controller " Paul Gortmaker
2016-11-04 20:33   ` Stephen Boyd
2016-07-04 21:12 ` [PATCH 05/10] clk: oxnas: make it " Paul Gortmaker
2016-07-06 13:11   ` Neil Armstrong
2016-07-06 22:21   ` Michael Turquette
2016-07-04 21:12 ` [PATCH 06/10] clk: samsung make clk-exynos-audss " Paul Gortmaker
2016-07-05  9:04   ` Krzysztof Kozlowski
2016-07-05 13:32     ` Paul Gortmaker [this message]
2016-07-05 11:02   ` Geert Uytterhoeven
2016-07-05 13:17     ` Paul Gortmaker
2016-07-07 13:12   ` Sylwester Nawrocki
2016-07-04 21:12 ` [PATCH 07/10] clk: samsung: make clk-s5pv210-audss " Paul Gortmaker
2016-07-06 10:49   ` Sylwester Nawrocki
2016-07-13 10:32   ` Sylwester Nawrocki
2016-07-13 21:59     ` Michael Turquette
2016-07-04 21:12 ` [PATCH 08/10] clk: sunxi: make clk-* " Paul Gortmaker
2016-07-04 21:36   ` Boris Brezillon
2016-07-05  6:13   ` Maxime Ripard
2016-07-06 22:22   ` Michael Turquette
2016-07-04 21:12 ` [PATCH 09/10] clk: tegra: make clk-tegra124-dfll-fcpu " Paul Gortmaker
2016-11-04 20:33   ` Stephen Boyd
2016-07-04 21:12 ` [PATCH 10/10] clk: ti: make clk-dra7-atl " Paul Gortmaker
2016-11-04 20:35   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705133216.GC26134@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@codeaurora.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).