From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755541AbcGFRuM (ORCPT ); Wed, 6 Jul 2016 13:50:12 -0400 Received: from mail.kernel.org ([198.145.29.136]:58238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755414AbcGFRuI (ORCPT ); Wed, 6 Jul 2016 13:50:08 -0400 Date: Wed, 6 Jul 2016 10:50:05 -0700 From: Jaegeuk Kim To: He YunLei Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Bintian Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: check only data or node for summary Message-ID: <20160706175005.GA80939@jaegeuk> References: <20160610210107.74181-1-jaegeuk@kernel.org> <577C8468.3060503@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577C8468.3060503@huawei.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 06, 2016 at 12:09:12PM +0800, He YunLei wrote: > On 2016/6/11 5:01, Jaegeuk Kim wrote: > > We can check data or node types only for gc, since we allocate different type of > > data/node blocks in a different logs occasionally. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/gc.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > > index e1d274c..c2c4ac3 100644 > > --- a/fs/f2fs/gc.c > > +++ b/fs/f2fs/gc.c > > @@ -806,7 +806,8 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, > > f2fs_put_page(sum_page, 0); > > > > sum = page_address(sum_page); > > - f2fs_bug_on(sbi, type != GET_SUM_TYPE((&sum->footer))); > > + f2fs_bug_on(sbi, IS_DATASEG(type) != > > + IS_DATASEG(GET_SUM_TYPE((&sum->footer)))); > > Hi, Kim > type has been transformed into SUM_TYPE_DATA or SUM_TYPE_NODE, so here > no need to do this. Oops, right. :) Thanks,