From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular
Date: Thu, 7 Jul 2016 11:11:30 +0300 [thread overview]
Message-ID: <20160707081130.GI23527@lahna.fi.intel.com> (raw)
In-Reply-To: <20160706163800.GH26134@windriver.com>
On Wed, Jul 06, 2016 at 12:38:00PM -0400, Paul Gortmaker wrote:
> [Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular] On 05/07/2016 (Tue 13:08) Mika Westerberg wrote:
>
> > On Mon, Jul 04, 2016 at 09:25:41PM -0400, Paul Gortmaker wrote:
> > > The Kconfig currently controlling compilation of this code is:
> > >
> > > drivers/mfd/Kconfig:config MFD_INTEL_MSIC
> > > drivers/mfd/Kconfig: bool "Intel MSIC"
> >
> > I would prefer if it could be turned to tristate instead. I don't see
> > any reasons why it should only be builtin.
>
> If I change it to tristate, it is still impossible to choose =m for it
> unless I revert your earlier commit forcing it to be built in.
>
> commit 15a713df4145ad2540f8d84c3f4de930806f6151
> Author: Mika Westerberg <mika.westerberg@linux.intel.com>
> Date: Thu Jan 26 17:35:05 2012 +0000
>
> x86/config: Select MSIC MFD driver on Intel Medfield platform
>
> On Intel Medfield platform we use MSIC MFD driver to create
> necessary platform devices so it is essential to have the driver
> compiled into the kernel.
>
> If I revert that, then it is possible to choose =m and it compiles.
> (haven't completed modpost yet.. so may be missing symbols...)
I think we can revert that and make it modular. Adding Andy just in case
I'm missing something obvious.
next prev parent reply other threads:[~2016-07-07 8:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 1:25 [PATCH 0/6] mfd: trivial demodularization of non-modular drivers Paul Gortmaker
2016-07-05 1:25 ` [PATCH 1/6] mfd: altera-a10sr: make it explicitly non-modular Paul Gortmaker
2016-08-05 12:57 ` Lee Jones
2016-08-23 20:56 ` Paul Gortmaker
2016-08-31 11:43 ` Lee Jones
2016-07-05 1:25 ` [PATCH 2/6] mfd: as3722: Make " Paul Gortmaker
2016-07-05 5:48 ` Laxman Dewangan
2016-07-06 16:45 ` Paul Gortmaker
2016-08-05 12:56 ` Lee Jones
2016-08-05 13:50 ` Paul Gortmaker
2016-08-08 9:14 ` Lee Jones
2016-08-08 14:01 ` Paul Gortmaker
2016-07-05 1:25 ` [PATCH 3/6] mfd: intel_msic: " Paul Gortmaker
2016-07-05 10:08 ` Mika Westerberg
2016-07-06 16:38 ` Paul Gortmaker
2016-07-07 8:11 ` Mika Westerberg [this message]
2016-07-07 10:26 ` Andy Shevchenko
2016-07-07 10:33 ` Mika Westerberg
2016-08-05 12:57 ` Lee Jones
2016-07-05 1:25 ` [PATCH 4/6] mfd: smsc-ece1099: " Paul Gortmaker
2016-08-05 12:57 ` Lee Jones
2016-07-05 1:25 ` [PATCH 5/6] mfd: sun6i-prcm: " Paul Gortmaker
2016-07-05 6:24 ` Maxime Ripard
2016-08-05 12:57 ` Lee Jones
2016-07-05 1:25 ` [PATCH 6/6] mfd: twl-core: " Paul Gortmaker
2016-08-05 12:58 ` Lee Jones
2016-09-12 14:40 [PATCH v2 0/6] mfd: trivial demodularization of non-modular drivers Paul Gortmaker
2016-09-12 14:40 ` [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular Paul Gortmaker
2016-09-13 8:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707081130.GI23527@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).