From: Greg Kurz <groug@kaod.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Thomas Huth <thuth@redhat.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
qemu-ppc@nongnu.org, linuxppc-dev@lists.ozlabs.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-ppc] [PATCH v2] powerpc/pseries: start rtasd before PCI probing
Date: Thu, 7 Jul 2016 19:26:07 +0200 [thread overview]
Message-ID: <20160707192607.7820a67e@bahia.lan> (raw)
In-Reply-To: <20160621110201.38d8711c@bahia.lan>
Ping ?
On Tue, 21 Jun 2016 11:02:01 +0200
Greg Kurz <groug@kaod.org> wrote:
> On Wed, 15 Jun 2016 22:26:41 +0200
> Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
>
> > A strange behaviour is observed when comparing PCI hotplug in QEMU, between
> > x86 and pseries. If you consider the following steps:
> > - start a VM
> > - add a PCI device via the QEMU monitor before the rtasd has started (for
> > example starting the VM in paused state, or hotplug during FW or boot
> > loader)
> > - resume the VM execution
> >
> > The x86 kernel detects the PCI device, but the pseries one does not.
> >
> > This happens because the rtasd kernel worker is currently started under
> > device_initcall, while PCI probing happens earlier under subsys_initcall.
> >
> > As a consequence, if we have a pending RTAS event at boot time, a message
> > is printed and the event is dropped.
> >
> > This patch moves all the initialization of rtasd to arch_initcall, which is
> > run before subsys_call: this way, logging_enabled is true when the RTAS
> > event pops up and it is not lost anymore.
> >
> > The proc fs bits stay at device_initcall because they cannot be run before
> > fs_initcall.
> >
> > Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> > ---
> > v2: - avoid behaviour change: don't create the proc entry if early init failed
> >
>
> I forgot to mention that Thomas had sent a Tested-by for v1, which I think is
> still valid for v2.
>
> > Michael,
> >
> > This was also tested under PowerVM: it doesn't fix anything there because the
> > HMC tells it won't honor DLPAR features as long as the RMC isn't here, which
> > happens later in the boot sequence. It hence seems impossible to have a pending
> > RTAS event at boot time.
> >
> > It doesn't seem to break anything either, the kernel boots and hotplug works
> > okay once the RMC is up.
> >
> > Cheers.
> >
> > --
> > Greg
> >
> > ---
> > arch/powerpc/kernel/rtasd.c | 22 +++++++++++++++++-----
> > 1 file changed, 17 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/rtasd.c b/arch/powerpc/kernel/rtasd.c
> > index e864b7c5884e..a26a02006576 100644
> > --- a/arch/powerpc/kernel/rtasd.c
> > +++ b/arch/powerpc/kernel/rtasd.c
> > @@ -526,10 +526,8 @@ void rtas_cancel_event_scan(void)
> > }
> > EXPORT_SYMBOL_GPL(rtas_cancel_event_scan);
> >
> > -static int __init rtas_init(void)
> > +static int __init rtas_event_scan_init(void)
> > {
> > - struct proc_dir_entry *entry;
> > -
> > if (!machine_is(pseries) && !machine_is(chrp))
> > return 0;
> >
> > @@ -562,13 +560,27 @@ static int __init rtas_init(void)
> > return -ENOMEM;
> > }
> >
> > + start_event_scan();
> > +
> > + return 0;
> > +}
> > +arch_initcall(rtas_event_scan_init);
> > +
> > +static int __init rtas_init(void)
> > +{
> > + struct proc_dir_entry *entry;
> > +
> > + if (!machine_is(pseries) && !machine_is(chrp))
> > + return 0;
> > +
> > + if (!rtas_log_buf)
> > + return -ENODEV;
> > +
> > entry = proc_create("powerpc/rtas/error_log", S_IRUSR, NULL,
> > &proc_rtas_log_operations);
> > if (!entry)
> > printk(KERN_ERR "Failed to create error_log proc entry\n");
> >
> > - start_event_scan();
> > -
> > return 0;
> > }
> > __initcall(rtas_init);
> >
> >
>
>
next prev parent reply other threads:[~2016-07-07 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 20:26 [PATCH v2] powerpc/pseries: start rtasd before PCI probing Greg Kurz
2016-06-21 9:02 ` [Qemu-ppc] " Greg Kurz
2016-07-07 17:26 ` Greg Kurz [this message]
2016-07-11 10:19 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707192607.7820a67e@bahia.lan \
--to=groug@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).