From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756783AbcGIMBg (ORCPT ); Sat, 9 Jul 2016 08:01:36 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37739 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756620AbcGIMBc (ORCPT ); Sat, 9 Jul 2016 08:01:32 -0400 Date: Sat, 9 Jul 2016 14:01:27 +0200 From: Ingo Molnar To: Brian Gerst Cc: Borislav Petkov , Borislav Petkov , the arch/x86 maintainers , Linux Kernel Mailing List , "H. Peter Anvin" , Denys Vlasenko , Andy Lutomirski , Thomas Gleixner Subject: Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame Message-ID: <20160709120127.GA26253@gmail.com> References: <1466283378-17062-1-git-send-email-brgerst@gmail.com> <1466283378-17062-6-git-send-email-brgerst@gmail.com> <20160620135158.GE22065@nazgul.tnic> <20160620151458.GD21957@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Brian Gerst wrote: > On Mon, Jun 20, 2016 at 11:14 AM, Borislav Petkov wrote: > > On Mon, Jun 20, 2016 at 11:01:02AM -0400, Brian Gerst wrote: > >> The idea was to put the uncommon case (kernel thread) out of line for > >> performance reasons. > > > > A comment saying so wouldn't hurt... > > This is a fairly common pattern. Do we have to document every case of it? Yeah, would be good to do that in general, so that people can re-evaluate whether 'this is rare' is still true years down the line. For newly touched code it makes sense to add a minimal comment that explains what is rare about the branch and so. Thanks, Ingo