From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933563AbcGKD0v (ORCPT ); Sun, 10 Jul 2016 23:26:51 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36581 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932250AbcGKD0t (ORCPT ); Sun, 10 Jul 2016 23:26:49 -0400 Date: Mon, 11 Jul 2016 11:19:05 +0800 From: Peter Chen To: Stephen Boyd Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Neil Armstrong , Arnd Bergmann , Felipe Balbi , Peter Chen , Greg Kroah-Hartman Subject: Re: [PATCH v2 11/22] usb: chipidea: msm: Mark device as runtime pm active Message-ID: <20160711031905.GD30448@shlinux2> References: <20160707222114.1673-1-stephen.boyd@linaro.org> <20160707222114.1673-12-stephen.boyd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160707222114.1673-12-stephen.boyd@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2016 at 03:21:02PM -0700, Stephen Boyd wrote: > We're not properly marking the glue layer/wrapper device as > runtime active, so runtime PM believes that the hardware state is > inactive when we call pm_runtime_enable() in this driver. This > causes a problem when the glue layer has a power domain > associated with it, because runtime PM will go and disable the > power domain to match the 'inactive' state of the device. Let's > mark the device as active so that runtime PM doesn't improperly > power down this device when it's actually active. > > Cc: Peter Chen > Cc: Greg Kroah-Hartman > Signed-off-by: Stephen Boyd > --- > drivers/usb/chipidea/ci_hdrc_msm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c > index 3889809fd0c4..89c1a02d69b5 100644 > --- a/drivers/usb/chipidea/ci_hdrc_msm.c > +++ b/drivers/usb/chipidea/ci_hdrc_msm.c > @@ -80,6 +80,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, plat_ci); > > + pm_runtime_set_active(&pdev->dev); > pm_runtime_no_callbacks(&pdev->dev); > pm_runtime_enable(&pdev->dev); > Acked-by: Peter Chen -- Best Regards, Peter Chen