LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Songshan Gong <gongss@linux.vnet.ibm.com>
Cc: acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC V1]s390/perf: fix 'start' address of module's map
Date: Mon, 11 Jul 2016 14:01:55 +0200
Message-ID: <20160711120155.GA29929@krava> (raw)
In-Reply-To: <657df05c-c0d9-7490-d374-f2fa4cdd7344@linux.vnet.ibm.com>

On Mon, Jul 11, 2016 at 07:06:14PM +0800, Songshan Gong wrote:

SNIP

> > 
> > we have following functions in tools/lib/api/fs to read
> > single number from file, which I assume you do above:
> > 
> > int sysfs__read_int(const char *entry, int *value);
> > int sysfs__read_ull(const char *entry, unsigned long long *value);
> > 
> > please check if you could use some of them,
> > we could add some more generic one if needed
> 
> It seems infeasible.
> Each value in /sys/module/[module name]/sections/.text is a string like
> "0x000003ff8130078\n".
> But the core function 'strtoull(line, NULL, 10)' in sysfs__read_ull is based
> on decimal.
> 
> Maybe you can introduce a new argument indicating the value is based on hex
> or decimal, or binary?

yea we could specify it directly and add something like:

  int filename__read_ull(const char *filename, unsigned long long *value, int base)

plus some other higher layer helpers..

but I wonder if we could use the base 0 (like in the attached patch),
the man page says it should be able to detect the base

we'd need to check all the current usage to make sure nothing gets broken

jirka


---
diff --git a/tools/lib/api/fs/fs.c b/tools/lib/api/fs/fs.c
index 08556cf2c70d..d18ae548468a 100644
--- a/tools/lib/api/fs/fs.c
+++ b/tools/lib/api/fs/fs.c
@@ -292,7 +292,7 @@ int filename__read_ull(const char *filename, unsigned long long *value)
 		return -1;
 
 	if (read(fd, line, sizeof(line)) > 0) {
-		*value = strtoull(line, NULL, 10);
+		*value = strtoull(line, NULL, 0);
 		if (*value != ULLONG_MAX)
 			err = 0;
 	}

  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07  1:49 Song Shan Gong
2016-07-08  2:17 ` Songshan Gong
2016-07-08 15:20   ` Jiri Olsa
2016-07-08 15:18 ` Jiri Olsa
2016-07-11  8:11   ` Songshan Gong
2016-07-13  3:32     ` Songshan Gong
2016-07-08 15:20 ` Jiri Olsa
2016-07-08 15:21 ` Jiri Olsa
2016-07-08 15:21 ` Jiri Olsa
2016-07-11 11:06   ` Songshan Gong
2016-07-11 12:01     ` Jiri Olsa [this message]
2016-07-13  6:39       ` Songshan Gong
2016-07-13  9:07         ` Jiri Olsa
2016-07-15  7:45           ` Songshan Gong
2016-07-15  8:27             ` Jiri Olsa
2016-07-15 13:23               ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160711120155.GA29929@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=gongss@linux.vnet.ibm.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git