From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Dmitry Safonov <dsafonov@virtuozzo.com>,
Michal Hocko <mhocko@suse.com>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Ingo Molnar <mingo@redhat.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
xemul@virtuozzo.com, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>
Subject: Re: [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*
Date: Mon, 11 Jul 2016 20:26:54 +0200 [thread overview]
Message-ID: <20160711182654.GA19160@redhat.com> (raw)
In-Reply-To: <CALCETrUEP-q-Be1i=L7hxX-nf4OpBv7edq2Mg0gi5TRX73FTsA@mail.gmail.com>
On 07/10, Andy Lutomirski wrote:
>
> On Thu, Jul 7, 2016 at 4:11 AM, Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> > On 07/06/2016 05:30 PM, Andy Lutomirski wrote:
> >>
> >> On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov <dsafonov@virtuozzo.com>
> >> wrote:
> >>>
> >>> Add API to change vdso blob type with arch_prctl.
> >>> As this is usefull only by needs of CRIU, expose
> >>> this interface under CONFIG_CHECKPOINT_RESTORE.
> >>
> >>
> >>> +#ifdef CONFIG_CHECKPOINT_RESTORE
> >>> + case ARCH_MAP_VDSO_X32:
> >>> + return do_map_vdso(VDSO_X32, addr, false);
> >>> + case ARCH_MAP_VDSO_32:
> >>> + return do_map_vdso(VDSO_32, addr, false);
> >>> + case ARCH_MAP_VDSO_64:
> >>> + return do_map_vdso(VDSO_64, addr, false);
> >>> +#endif
> >>> +
> >>
> >>
> >> This will have an odd side effect: if the old mapping is still around,
> >> its .fault will start behaving erratically.
Yes but I am not sure I fully understand your concerns, so let me ask...
Do we really care? I mean, the kernel can't crash or something like this,
just the old vdso mapping can faultin the "wrong" page from the new
vdso_image, right?
The user of prctl(ARCH_MAP_VDSO) should understand what it does and unmap
the old vdso anyway.
> >> I wonder if we can either
> >> reliably zap the old vma (or check that it's not there any more)
> >> before mapping a new one
However, I think this is right anyway, please see below...
> >> or whether we can associate the vdso image
> >> with the vma (possibly by having a separate vm_special_mapping for
> >> each vdso_image.
Yes, I too thought it would be nice to do this, regardless.
But as you said we probably want to limit the numbet of special mappings
an application can create:
> >> I'm also a bit concerned that __install_special_mapping might not get
> >> all the cgroup and rlimit stuff right. If we ensure that any old
> >> mappings are gone, then the damage is bounded, but otherwise someone
> >> might call this in a loop and fill their address space with arbitrary
> >> numbers of special mappings.
I think you are right, we should not allow user-space to abuse the special
mappings. Even if iiuc in this case only RLIMIT_AS does matter...
> Oleg, want to sanity-check us? Do you believe that if .mremap ensures
> that only entire vma can be remapped
Yes I think this makes sense. And damn we should kill arch_remap() ;)
> and .close ensures that only the
> whole vma can be unmapped,
How? It can't return the error.
And do_munmap() doesn't necessarily call ->close(),
> Or will we have issues with
> mprotect?
Yes, __split_vma() doesn't call ->close() too. ->open() can't help...
So it seems that we should do this by hand somehow. But in fact, what
I actually think right now is that I am totally confused and got lost ;)
Oleg.
next prev parent reply other threads:[~2016-07-11 18:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 10:57 [PATCHv2 0/6] x86: 32-bit compatible C/R on x86_64 Dmitry Safonov
2016-06-29 10:57 ` [PATCHv2 1/6] x86/vdso: unmap vdso blob on vvar mapping failure Dmitry Safonov
2016-07-06 14:16 ` Andy Lutomirski
2016-06-29 10:57 ` [PATCHv2 2/6] x86/vdso: introduce do_map_vdso() and vdso_type enum Dmitry Safonov
2016-07-06 14:21 ` Andy Lutomirski
2016-07-07 11:04 ` Dmitry Safonov
2016-06-29 10:57 ` [PATCHv2 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_* Dmitry Safonov
2016-07-06 14:30 ` Andy Lutomirski
2016-07-07 11:11 ` Dmitry Safonov
2016-07-10 12:44 ` Andy Lutomirski
2016-07-11 18:26 ` Oleg Nesterov [this message]
2016-07-11 18:28 ` Andy Lutomirski
2016-07-12 14:14 ` Oleg Nesterov
2016-08-02 10:59 ` Dmitry Safonov
2016-08-10 8:35 ` Andy Lutomirski
2016-08-10 10:49 ` Dmitry Safonov
2016-06-29 10:57 ` [PATCHv2 4/6] x86/coredump: use pr_reg size, rather that TIF_IA32 flag Dmitry Safonov
2016-06-29 10:57 ` [PATCHv2 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32) Dmitry Safonov
2016-07-06 14:32 ` Andy Lutomirski
2016-06-29 10:57 ` [PATCHv2 6/6] x86/signal: add SA_{X32,IA32}_ABI sa_flags Dmitry Safonov
2016-07-06 14:36 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711182654.GA19160@redhat.com \
--to=oleg@redhat.com \
--cc=0x7f454c46@gmail.com \
--cc=dsafonov@virtuozzo.com \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vdavydov@virtuozzo.com \
--cc=x86@kernel.org \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).