From: Herbert Xu <herbert@gondor.apana.org.au>
To: Yeshaswi M R Gowda <yeshaswi@chelsio.com>
Cc: hariprasad@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
linux-crypto@vger.kernel.org, jlulla@chelsio.com,
atul.gupta@chelsio.com, harsh@chelsio.com
Subject: Re: [PATCH 2/3] chcr: Support for Chelsio's Crypto Hardware
Date: Tue, 12 Jul 2016 16:35:52 +0800 [thread overview]
Message-ID: <20160712083552.GA29994@gondor.apana.org.au> (raw)
In-Reply-To: <1468261688-24525-3-git-send-email-yeshaswi@chelsio.com>
On Mon, Jul 11, 2016 at 11:28:07AM -0700, Yeshaswi M R Gowda wrote:
>
> + u_ctx = ULD_CTX(ctx);
> + if (cxgb4_is_crypto_q_full(u_ctx->lldi.ports[0], ctx->tx_channel_id))
> + return -EBUSY;
You cannot just return -EBUSY. If the request has the MAY_BACKLOG
bit set, it must be queued regardless, but you should return -EBUSY
in order to throttle the user and then call the completion function
with -EINPROGRESS once the queue can accept more requests from the
user.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-07-12 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 18:28 [PATCH 0/3] crypto/chcr: Add Chelsio Crypto Driver Yeshaswi M R Gowda
2016-07-11 18:28 ` [PATCH 1/3] cxgb4: Add Chelsio LLD support Chelsio Crypto ULD Yeshaswi M R Gowda
2016-07-11 18:28 ` [PATCH 2/3] chcr: Support for Chelsio's Crypto Hardware Yeshaswi M R Gowda
2016-07-11 18:57 ` Joe Perches
2016-07-12 8:35 ` Herbert Xu [this message]
2016-07-11 18:28 ` [PATCH 3/3] crypto: Added Chelsio Menu to the Kconfig file Yeshaswi M R Gowda
2016-07-11 19:30 ` kbuild test robot
2016-07-12 8:44 ` Herbert Xu
2016-07-12 0:14 ` kbuild test robot
2016-07-12 4:36 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712083552.GA29994@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=atul.gupta@chelsio.com \
--cc=davem@davemloft.net \
--cc=hariprasad@chelsio.com \
--cc=harsh@chelsio.com \
--cc=jlulla@chelsio.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yeshaswi@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).