From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753802AbcGLMhe (ORCPT ); Tue, 12 Jul 2016 08:37:34 -0400 Received: from smtprelay0051.hostedemail.com ([216.40.44.51]:55976 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751179AbcGLMhc (ORCPT ); Tue, 12 Jul 2016 08:37:32 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3870:4321:5007:6261:7875:7901:10004:10400:10450:10455:10848:10967:11026:11232:11657:11658:11914:12043:12517:12519:12555:12740:13069:13311:13357:13439:14181:14659:14721:19904:19999:21080:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: ray37_7346d00db333 X-Filterd-Recvd-Size: 2201 Date: Tue, 12 Jul 2016 08:37:28 -0400 From: Steven Rostedt To: Jiri Olsa Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: Re: [PATCH 10/10] perf script python: Fix string vs byte array resolving Message-ID: <20160712083728.2c468986@gandalf.local.home> In-Reply-To: <20160712081156.GB3392@krava> References: <1468148882-10362-1-git-send-email-jolsa@kernel.org> <1468148882-10362-11-git-send-email-jolsa@kernel.org> <20160711115452.02ba1d6c@gandalf.local.home> <20160712081156.GB3392@krava> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jul 2016 10:11:56 +0200 Jiri Olsa wrote: > --- > diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c > index 75e9790ebb96..9f810e6c739a 100644 > --- a/tools/perf/util/scripting-engines/trace-event-python.c > +++ b/tools/perf/util/scripting-engines/trace-event-python.c > @@ -390,11 +390,13 @@ static int is_printable_array(char *p, unsigned int len) > { > unsigned int i; > > - for (i = 0; i < len; i++) > + /* Exclude the last zero byte of string.. */ > + for (i = 0; i < len - 1; i++) > if (!isprint(p[i]) && !isspace(p[i])) > return 0; > > - return 1; > + /* ... and check its presence in the last byte. */ > + return p[i] == 0; > } > Of course this fails on: is_printable_array(a, strlen(a)); because the last byte wont be 0. What about: for (i = 0; i < len; i++) if (!isprint(p[i]) && !isspace(p[i])) break; return i == len || (i == len - 1 && p[i] == 0); -- Steve