From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbcGLXct (ORCPT ); Tue, 12 Jul 2016 19:32:49 -0400 Received: from mail.kernel.org ([198.145.29.136]:35530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbcGLXcm (ORCPT ); Tue, 12 Jul 2016 19:32:42 -0400 Date: Tue, 12 Jul 2016 20:32:18 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , David Ahern , Jiri Olsa , Namhyung Kim , Wang Nan Subject: Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Message-ID: <20160712233218.GB26691@kernel.org> References: <1468363241-14555-1-git-send-email-acme@kernel.org> <1468363241-14555-30-git-send-email-acme@kernel.org> <20160712191108.63d23fae@gandalf.local.home> <20160712231424.GA26691@kernel.org> <20160712192519.601b1fae@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160712192519.601b1fae@gandalf.local.home> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jul 12, 2016 at 07:25:19PM -0400, Steven Rostedt escreveu: > On Tue, 12 Jul 2016 20:14:24 -0300 > Arnaldo Carvalho de Melo wrote: > > > Em Tue, Jul 12, 2016 at 07:11:08PM -0400, Steven Rostedt escreveu: > > > On Tue, 12 Jul 2016 19:40:04 -0300 Arnaldo Carvalho de Melo wrote: > > > > To make it portable to non-glibc systems, that follow the XSI variant > > > > instead of the GNU specific one that gets in place when _GNU_SOURCE is > > > > defined. > > > > > > #include "event-parse.h" > > > > @@ -6131,12 +6132,7 @@ int pevent_strerror(struct pevent *pevent __maybe_unused, > > > > + str_error_r(errnum, buf, buflen); > > > > return 0; > > > What library is used with this? When I port this over to trace-cmd > > > (which is still needed as I develop this there), it fails to build. > > > "undefined reference to str_error_r" > > tools/lib/str_error_r.c > > Forgot about the out of tree copy :-\ > Yeah, we really need to make this into a real library. I haven't had > the time to do that. Hopefully in August I can talk with some people at What exactly do you mean by that? To grab a copy of what is in tools/ and have it turned into a library somewhere else? Or to freeze its interfaces and create an .so with a committed to ABI? I kind of like the way it is now... :-) > LinuxCon to see the best way to go about doing that. > > Anyway, I may just take that file and port it to trace-cmd. Yeah, that would solve this specific case. - Arnaldo