From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932131AbcGMJH4 (ORCPT ); Wed, 13 Jul 2016 05:07:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53779 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbcGMJHt (ORCPT ); Wed, 13 Jul 2016 05:07:49 -0400 Date: Wed, 13 Jul 2016 11:07:42 +0200 From: Jiri Olsa To: Songshan Gong Cc: acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC V1]s390/perf: fix 'start' address of module's map Message-ID: <20160713090742.GB28676@krava> References: <1467856176-8712-1-git-send-email-gongss@linux.vnet.ibm.com> <20160708152133.GK31763@krava> <657df05c-c0d9-7490-d374-f2fa4cdd7344@linux.vnet.ibm.com> <20160711120155.GA29929@krava> <6aba748e-0669-34e0-b056-4a76ed141c08@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6aba748e-0669-34e0-b056-4a76ed141c08@linux.vnet.ibm.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 13 Jul 2016 09:07:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2016 at 02:39:13PM +0800, Songshan Gong wrote: > > > 在 7/11/2016 8:01 PM, Jiri Olsa 写道: > > On Mon, Jul 11, 2016 at 07:06:14PM +0800, Songshan Gong wrote: > > > > SNIP > > > > > > > > > > we have following functions in tools/lib/api/fs to read > > > > single number from file, which I assume you do above: > > > > > > > > int sysfs__read_int(const char *entry, int *value); > > > > int sysfs__read_ull(const char *entry, unsigned long long *value); > > > > > > > > please check if you could use some of them, > > > > we could add some more generic one if needed > > > > > > It seems infeasible. > > > Each value in /sys/module/[module name]/sections/.text is a string like > > > "0x000003ff8130078\n". > > > But the core function 'strtoull(line, NULL, 10)' in sysfs__read_ull is based > > > on decimal. > > > > > > Maybe you can introduce a new argument indicating the value is based on hex > > > or decimal, or binary? > > > > yea we could specify it directly and add something like: > > > > int filename__read_ull(const char *filename, unsigned long long *value, int base) > > > > plus some other higher layer helpers.. > > > > but I wonder if we could use the base 0 (like in the attached patch), > > the man page says it should be able to detect the base > > > > we'd need to check all the current usage to make sure nothing gets broken > > > > jirka > > > > > > Since your patch havn't pushed to devel branch, my next version patch will > still use the origin method to parse value from /sys/. I'll make/send the change during this week, jirka