linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] mm, meminit: Always return a valid node from early_pfn_to_nid
Date: Wed, 13 Jul 2016 11:34:21 +0100	[thread overview]
Message-ID: <20160713103421.GJ9806@techsingularity.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1607121624450.118757@chino.kir.corp.google.com>

On Tue, Jul 12, 2016 at 04:26:02PM -0700, David Rientjes wrote:
> On Fri, 8 Jul 2016, Mel Gorman wrote:
> 
> > early_pfn_to_nid can return node 0 if a PFN is invalid on machines
> > that has no node 0. A machine with only node 1 was observed to crash
> > with the following message
> > 
> >  BUG: unable to handle kernel paging request at 000000000002a3c8
> >  PGD 0
> >  Modules linked in:
> >  Hardware name: Supermicro H8DSP-8/H8DSP-8, BIOS 080011  06/30/2006
> >  task: ffffffff81c0d500 ti: ffffffff81c00000 task.ti: ffffffff81c00000
> >  RIP: 0010:[<ffffffff816dbd63>]  [<ffffffff816dbd63>] reserve_bootmem_region+0x6a/0xef
> >  RSP: 0000:ffffffff81c03eb0  EFLAGS: 00010086
> >  RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
> >  RDX: ffffffff81c03ec0 RSI: ffffffff81d205c0 RDI: ffffffff8213ee60
> >  R13: ffffea0000000000 R14: ffffea0000000020 R15: ffffea0000000020
> >  FS:  0000000000000000(0000) GS:ffff8800fba00000(0000) knlGS:0000000000000000
> >  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> >  CR2: 000000000002a3c8 CR3: 0000000001c06000 CR4: 00000000000006b0
> >  Stack:
> >   ffffffff81c03f00 0000000000000400 ffff8800fbfc3200 ffffffff81e2a2c0
> >   ffffffff81c03fb0 ffffffff81c03f20 ffffffff81dadf7d ffffea0002000040
> >   ffffea0000000000 0000000000000000 000000000000ffff 0000000000000001
> >  Call Trace:
> >   [<ffffffff81dadf7d>] free_all_bootmem+0x4b/0x12a
> >   [<ffffffff81d97122>] mem_init+0x70/0xa3
> >   [<ffffffff81d78f21>] start_kernel+0x25b/0x49b
> > 
> > The problem is that early_page_uninitialised uses the early_pfn_to_nid
> > helper which returns node 0 for invalid PFNs. No caller of early_pfn_to_nid
> > cares except early_page_uninitialised. This patch has early_pfn_to_nid
> > always return a valid node.
> > 
> > Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> > Cc: <stable@vger.kernel.org> # 4.2+
> 
> Acked-by: David Rientjes <rientjes@google.com>
> 
> This makes me wonder about meminit_pfn_in_nid(), however, since if 
> __early_pfn_to_nid() returns -1, which is the case in this bug, 
> meminit_pfn_in_nid() will return true for any passed node.

I felt it was ok because it's checking for overlapping nodes primarily.
If there is a hole, the pfn_valid check should fail for sparsemem. For
flatmem, there is no concern with overlapping nodes. Technically the
meminit_pfn_in_nid() call can return true for a hole but for sparsemem,
that is checked for by pfn_valid and for flatmem, it doesn't matter.

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2016-07-13 10:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 20:00 [PATCH 0/3] Fix boot problem with deferred meminit on machine with no node 0 Mel Gorman
2016-07-08 20:00 ` [PATCH 1/3] mm, meminit: Remove early_page_nid_uninitialised Mel Gorman
2016-07-08 20:00 ` [PATCH 2/3] mm, meminit: Always return a valid node from early_pfn_to_nid Mel Gorman
2016-07-12 23:26   ` David Rientjes
2016-07-13 10:34     ` Mel Gorman [this message]
2016-07-08 20:00 ` [PATCH 3/3] mm, meminit: Ensure node is online before checking whether pages are uninitialised Mel Gorman
2016-07-12 23:28   ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160713103421.GJ9806@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).