From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752861AbcGMOHA (ORCPT ); Wed, 13 Jul 2016 10:07:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52716 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbcGMOG7 (ORCPT ); Wed, 13 Jul 2016 10:06:59 -0400 Date: Wed, 13 Jul 2016 16:06:30 +0200 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com, He Kuang , Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Nilay Vaish Subject: Re: [PATCH v15 09/12] perf record: Read from overwritable ring buffer Message-ID: <20160713140630.GA31742@krava> References: <1468317612-11598-1-git-send-email-wangnan0@huawei.com> <1468317612-11598-10-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468317612-11598-10-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 13 Jul 2016 14:06:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2016 at 10:00:09AM +0000, Wang Nan wrote: SNIP > + * (1): Pause ring buffers for reading > + * (2): Read from ring buffers > + * (3): Resume ring buffers for recording > + */ > +enum overwrite_evt_state { > + OVERWRITE_EVT_RUNNING, > + OVERWRITE_EVT_DATA_PENDING, > + OVERWRITE_EVT_EMPTY, > +}; > > struct record { > struct perf_tool tool; > @@ -61,6 +85,7 @@ struct record { > bool buildid_all; > bool timestamp_filename; > bool switch_output; > + enum overwrite_evt_state overwrite_evt_state; > unsigned long long samples; I wonder this would be better to have in 'struct evlist', also 'enum owr_mmap_state' might be better name then thanks, jirka