From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751229AbcGMUzM (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jul 2016 16:55:12 -0400
Received: from merlin.infradead.org ([205.233.59.134]:45047 "EHLO
	merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750904AbcGMUzF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jul 2016 16:55:05 -0400
Date: Wed, 13 Jul 2016 22:54:49 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Alexander Yarygin <yarygin@linux.vnet.ibm.com>,
        Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
        Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Chris Phlipot <cphlipot0@gmail.com>,
        Christoffer Dall <christoffer.dall@linaro.org>,
        David Ahern <dsahern@gmail.com>, Davidlohr Bueso <dbueso@suse.de>,
        David Tolnay <dtolnay@gmail.com>, Eric Auger <eric.auger@linaro.org>,
        Hemant Kumar <hemant@linux.vnet.ibm.com>,
        Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
        Jiri Olsa <jolsa@kernel.org>, Marc Zyngier <marc.zyngier@arm.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        "Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Vineet Gupta <vgupta@synopsys.com>, Wang Nan <wangnan0@huawei.com>,
        Yunlong Song <yunlong.song@huawei.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL 00/66] perf/core improvements and fixes
Message-ID: <20160713205449.GA30909@twins.programming.kicks-ass.net>
References: <1468363241-14555-1-git-send-email-acme@kernel.org>
 <20160713065906.GA13006@gmail.com>
 <20160713073527.GA28210@gmail.com>
 <20160713204914.zs77db76wuvharn6@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160713204914.zs77db76wuvharn6@treble>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2016 at 03:49:14PM -0500, Josh Poimboeuf wrote:
> That '#define BITS_PER_LONG 32' comes from the following code in
> tools/include/asm-generic/bitsperlong.h:
> 
>   #ifdef CONFIG_64BIT
>   #define BITS_PER_LONG 64
>   #else
>   #define BITS_PER_LONG 32
>   #endif /* CONFIG_64BIT */
> 
> Because objtool doesn't have CONFIG_64BIT defined, it falls through to
> the '#else' condition.  I think tools code shouldn't be relying on
> kernel config options.

Right.. __LP64__ would work in general I think, or __SIZEOF_LONG__ *
__CHAR_BIT__.