From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751662AbcGNG2c (ORCPT ); Thu, 14 Jul 2016 02:28:32 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33963 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbcGNG2W (ORCPT ); Thu, 14 Jul 2016 02:28:22 -0400 Date: Thu, 14 Jul 2016 08:28:19 +0200 From: Jiri Pirko To: Christophe JAILLET Cc: jiri@mellanox.com, idosch@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error Message-ID: <20160714062819.GB2228@nanopsycho.orion> References: <1468477125-3153-1-git-send-email-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468477125-3153-1-git-send-email-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thu, Jul 14, 2016 at 08:18:45AM CEST, christophe.jaillet@wanadoo.fr wrote: >'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong. >Return an explicit error code (-ENOENT) instead. > This is fo net-next. Fixes: 61c503f976 ("mlxsw: spectrum_router: Implement fib4 add/del switchdev obj ops") >Signed-off-by: Christophe JAILLET Acked-by: Jiri Pirko Thanks.