From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
"Arjan van de Ven" <arjan@linux.intel.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"David Vrabel" <david.vrabel@citrix.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Juergen Gross" <jgross@suse.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
kvm@vger.kernel.org, x86@kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 0/8] x86: audit and remove needless module.h includes
Date: Thu, 14 Jul 2016 11:18:39 -0400 [thread overview]
Message-ID: <20160714151835.GO4194@windriver.com> (raw)
In-Reply-To: <20160714130443.GA27637@gmail.com>
[Re: [PATCH 0/8] x86: audit and remove needless module.h includes] On 14/07/2016 (Thu 15:04) Ingo Molnar wrote:
>
> * Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
> > To that end, I have done allmodconfig, allyesconfig and allnoconfig
> > for both 32 bit and 64 bit x86 with these changes on the linux-next
> > from today, which presumably has an up to date copy of tip in it.
>
> It does, still I get this on allnoconfig with your patches applied:
Took me a while to figure out why I didn't see this; I was able to
finally reproduce it on x86-32 with allnoconfig but CONFIG_SMP=y.
>
> arch/x86/kernel/setup_percpu.c: In function ‘setup_percpu_segment’:
> arch/x86/kernel/setup_percpu.c:159:2: error: implicit declaration of function
> ‘pack_descriptor’ [-Werror=implicit-function-declaration]
> pack_descriptor(&gdt, per_cpu_offset(cpu), 0xFFFFF,
> ^
> arch/x86/kernel/setup_percpu.c:162:2: error: implicit declaration of function
> ‘write_gdt_entry’ [-Werror=implicit-function-declaration]
> write_gdt_entry(get_cpu_gdt_table(cpu),
> ^
> arch/x86/kernel/setup_percpu.c:162:18: error: implicit declaration of function
> ‘get_cpu_gdt_table’ [-Werror=implicit-function-declaration]
> write_gdt_entry(get_cpu_gdt_table(cpu),
All three of these guys live in asm/desc.h and adding that to the top of
arch/x86/kernel/setup_percpu.c asm include list seems to fix the
reproducer I now have here.
>
> I'll continue testing with the setup_percpu.c change left out.
Let me know if you want a resend or if you want to just add the
asm/desc.h locally or ...
Paul.
--
>
> Thanks,
>
> Ingo
next prev parent reply other threads:[~2016-07-14 15:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 0:18 [PATCH 0/8] x86: audit and remove needless module.h includes Paul Gortmaker
2016-07-14 0:18 ` [PATCH 1/8] x86: don't use module.h just for AUTHOR / LICENSE tags Paul Gortmaker
2016-07-14 0:22 ` Arjan van de Ven
2016-07-14 18:43 ` [tip:x86/headers] x86: Don't " tip-bot for Paul Gortmaker
2016-07-14 0:18 ` [PATCH 2/8] x86: mm: audit and remove any unnecessary uses of module.h Paul Gortmaker
2016-07-14 18:43 ` [tip:x86/headers] x86/mm: Audit " tip-bot for Paul Gortmaker
2016-07-14 0:18 ` [PATCH 3/8] x86: kernel: audit " Paul Gortmaker
2016-07-14 18:43 ` [tip:x86/headers] x86/kernel: Audit " tip-bot for Paul Gortmaker
2016-07-14 0:18 ` [PATCH 4/8] x86: lib: audit " Paul Gortmaker
2016-07-14 18:44 ` [tip:x86/headers] x86/lib: Audit " tip-bot for Paul Gortmaker
2016-07-14 0:18 ` [PATCH 5/8] x86: platform: audit " Paul Gortmaker
2016-07-14 18:44 ` [tip:x86/headers] x86/platform: Audit " tip-bot for Paul Gortmaker
2016-07-14 0:18 ` [PATCH 6/8] x86: xen: audit " Paul Gortmaker
2016-07-14 3:59 ` Juergen Gross
2016-07-14 18:45 ` [tip:x86/headers] x86/xen: Audit " tip-bot for Paul Gortmaker
2016-07-14 0:19 ` [PATCH 7/8] x86: kvm: audit " Paul Gortmaker
2016-07-14 7:42 ` Paolo Bonzini
2016-07-14 18:45 ` [tip:x86/headers] x86/kvm: Audit " tip-bot for Paul Gortmaker
2016-07-14 0:19 ` [PATCH 8/8] x86: audit and remove any remaining " Paul Gortmaker
2016-07-14 18:45 ` [tip:x86/headers] x86: Audit " tip-bot for Paul Gortmaker
2016-07-14 13:04 ` [PATCH 0/8] x86: audit and remove needless module.h includes Ingo Molnar
2016-07-14 15:18 ` Paul Gortmaker [this message]
2016-07-14 18:39 ` Ingo Molnar
2016-07-14 18:46 ` Paul Gortmaker
2016-07-14 18:56 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714151835.GO4194@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=arjan@linux.intel.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).