From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752099AbcGNS43 (ORCPT ); Thu, 14 Jul 2016 14:56:29 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:33344 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbcGNS40 (ORCPT ); Thu, 14 Jul 2016 14:56:26 -0400 Date: Thu, 14 Jul 2016 20:56:21 +0200 From: Ingo Molnar To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Arjan van de Ven , Boris Ostrovsky , David Vrabel , "H. Peter Anvin" , Ingo Molnar , Juergen Gross , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Thomas Gleixner , kvm@vger.kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 0/8] x86: audit and remove needless module.h includes Message-ID: <20160714185621.GA21092@gmail.com> References: <20160714001901.31603-1-paul.gortmaker@windriver.com> <20160714130443.GA27637@gmail.com> <20160714151835.GO4194@windriver.com> <20160714183903.GA16975@gmail.com> <20160714184603.GR4194@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160714184603.GR4194@windriver.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Paul Gortmaker wrote: > [Re: [PATCH 0/8] x86: audit and remove needless module.h includes] On 14/07/2016 (Thu 20:39) Ingo Molnar wrote: > > > > > * Paul Gortmaker wrote: > > > > > > I'll continue testing with the setup_percpu.c change left out. > > > > > > Let me know if you want a resend or if you want to just add the > > > asm/desc.h locally or ... > > > > So I tried the asm/desc.h but saw other build failures - for now gave up. > > Can we do this in a separate patch? > > Yes of course. In the meantime I'll investigate further and add more > configs to my testing. Is there a list of the configs used for sanity > testing tip somewhere? No need for you to complicate your testing (unless you have enough hardware resources for that) - I can deal with the occasional build failure. Since I eventually create and boot randconfigs there's no fixed set of configs. :-/ That I enabled SMP on the "allnoconfig" (and forgot about it!) has to do with the fact that even my allnoconfigs are typically bootable (on one of my test systems) so there's a handful of pre-baked configs that always get enabled. But other than those small perturbations I do similar testing to what you did: all{no|def|mod|yes}config on x86-{32|64}, plus randconfigs. Thanks, Ingo