From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751462AbcGOVxt (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Jul 2016 17:53:49 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:55058 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751080AbcGOVxr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Jul 2016 17:53:47 -0400
Date: Fri, 15 Jul 2016 14:53:45 -0700 (PDT)
Message-Id: <20160715.145345.1714630247405044715.davem@davemloft.net>
To: amir.jer.levy@intel.com
Cc: andreas.noever@gmail.com, gregkh@linuxfoundation.org, bhelgaas@google.com,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, thunderbolt-linux@intel.com,
        mika.westerberg@intel.com, tomas.winkler@intel.com
Subject: Re: [PATCH v3 2/8] thunderbolt: Updating device IDs
From: David Miller <davem@davemloft.net>
In-Reply-To: <E607265CB020454880711A6F96C05A03893CE285@hasmsx107.ger.corp.intel.com>
References: <1468495702-7467-3-git-send-email-amir.jer.levy@intel.com>
	<20160715.114902.1149848183971707484.davem@davemloft.net>
	<E607265CB020454880711A6F96C05A03893CE285@hasmsx107.ger.corp.intel.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Jul 2016 14:53:46 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Levy, Amir (Jer)" <amir.jer.levy@intel.com>
Date: Fri, 15 Jul 2016 18:56:39 +0000

> On Fri, Jul 15 2016, 09:49 PM, David Miller wrote:
>> From: Amir Levy <amir.jer.levy@intel.com>
>> Date: Thu, 14 Jul 2016 14:28:16 +0300
>> 
>> > Adding the new Thunderbolt(TM) device IDs to the list.
>> >
>> > Signed-off-by: Amir Levy <amir.jer.levy@intel.com>
>> 
>> Unless these PCI-IDs, all of them, are going to be used in multiple spots in the
>> kernel, it is not appropriate to add them here.
>> 
>> They belong as private macros in the drivers themselves, instead.
> 
> They might be used: http://www.spinics.net/lists/linux-pci/msg51331.html

Then move them to the common location when this "might" thing actually
happens.