From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbcGODN6 (ORCPT ); Thu, 14 Jul 2016 23:13:58 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:34994 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbcGODN4 (ORCPT ); Thu, 14 Jul 2016 23:13:56 -0400 Date: Thu, 14 Jul 2016 21:13:51 -0600 From: Jason Gunthorpe To: Andrey Pronin Cc: Jarkko Sakkinen , Peter Huewe , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org Subject: Re: [PATCH 1/2] tpm_tis_core: add optional max xfer size check Message-ID: <20160715031351.GD9347@obsidianresearch.com> References: <1468546745-14646-1-git-send-email-apronin@chromium.org> <1468546745-14646-2-git-send-email-apronin@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468546745-14646-2-git-send-email-apronin@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 06:39:04PM -0700, Andrey Pronin wrote: > +static inline u16 tpm_tis_max_xfer_size(struct tpm_tis_data *data) > +{ > + return data->phy_ops->max_xfer_size; > +} > + > +static inline bool tpm_tis_burstcnt_is_valid(struct tpm_tis_data *data, > + u16 burstcnt) > +{ > + return (tpm_tis_max_xfer_size(data) == 0) > + || (burstcnt <= tpm_tis_max_xfer_size(data)); > +} We don't need these accessors, just open code it in the one call site. That is more clear as the ==0 case is important to understand that the flow is correct. BTW, I dodn't think || as the start of a line was cannonical kernel style.. Did checkpatch accept that? Jason