From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751340AbcGOPBD (ORCPT ); Fri, 15 Jul 2016 11:01:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55562 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbcGOPBB (ORCPT ); Fri, 15 Jul 2016 11:01:01 -0400 Date: Fri, 15 Jul 2016 17:00:57 +0200 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com, Arnaldo Carvalho de Melo , He Kuang , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Nilay Vaish Subject: Re: [PATCH v16 00/15] perf tools: Support overwritable ring buffer Message-ID: <20160715150057.GC29695@krava> References: <1468485287-33422-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468485287-33422-1-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 15 Jul 2016 15:01:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 08:34:32AM +0000, Wang Nan wrote: SNIP > > v15 -> v16: Follow Jiri Olsa's suggestion: > 1. Move backward ring buffer state machine to evlist. > 2. Dynamically allocate backward mmap, so backward_mmap == NULL > means there's no backward ring buffer. > Stop the state machine when there's no backward ring buffer. > 3. Rename: _output2 to _output_backward. > 4. Patch rearrangement. > 5. Update record__pick_pc(): read from backward_mmap if normal > mmap is empty. > > Arnaldo Carvalho de Melo (1): > perf tools: Drop redundant evsel->overwrite indicator > > Wang Nan (14): > tools lib fd array: Allow associating a pointer cookie with each entry > perf tools: Update perf evlist mmap related APIs and helpers > perf tools: Decouple record__mmap_read() and evlist. > perf tools: Record mmap cookie into fdarray private field > perf tools: Extract common code in mmap failure processing > perf tools: Introduce backward_mmap array for evlist > perf tools: Map backward events to backward_mmap > perf tools: Drop evlist->backward > perf tools: Setup backward mmap state machine > perf record: Read from overwritable ring buffer > perf tools: Make perf_evlist__{pause,resume} internal helpers > perf tools: Enable overwrite settings > perf tools: Don't warn about out of order event if write_backward is > used > perf tools: Add --tail-synthesize option looks good to me now ;-) Acked-by: Jiri Olsa thanks, jirka