From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751353AbcGOPBr (ORCPT ); Fri, 15 Jul 2016 11:01:47 -0400 Received: from outbound-smtp10.blacknight.com ([46.22.139.15]:41810 "EHLO outbound-smtp10.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbcGOPBp (ORCPT ); Fri, 15 Jul 2016 11:01:45 -0400 Date: Fri, 15 Jul 2016 16:01:40 +0100 From: Mel Gorman To: Minchan Kim Cc: Andrew Morton , Johannes Weiner , Vlastimil Babka , Linux-MM , LKML Subject: Re: [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg Message-ID: <20160715150140.GP9806@techsingularity.net> References: <1468588165-12461-1-git-send-email-mgorman@techsingularity.net> <1468588165-12461-6-git-send-email-mgorman@techsingularity.net> <20160715144534.GA8644@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20160715144534.GA8644@bbox> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2016 at 11:45:34PM +0900, Minchan Kim wrote: > > +static __always_inline void update_lru_sizes(struct lruvec *lruvec, > > + enum lru_list lru, unsigned long *nr_zone_taken, > > + unsigned long nr_taken) > > +{ > > +#ifdef CONFIG_HIGHMEM > > If you think it's really worth to optimize it for non-highmem system, > we don't need to account nr_zone_taken in *isolate_lru_pages* > from the beginning for non-highmem system, either. > It becomes a mess of ifdefs and given the marginal overhead, I left it for now. -- Mel Gorman SUSE Labs