From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbcGOW11 (ORCPT ); Fri, 15 Jul 2016 18:27:27 -0400 Received: from mail.kernel.org ([198.145.29.136]:42978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbcGOW1Y (ORCPT ); Fri, 15 Jul 2016 18:27:24 -0400 Date: Fri, 15 Jul 2016 19:27:21 -0300 From: Arnaldo Carvalho de Melo To: Dan Carpenter Cc: Peter Zijlstra , Stephane Eranian , Ingo Molnar , Alexander Shishkin , Adrian Hunter , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch 2/2] perf jit: remove some no-op error handling Message-ID: <20160715222721.GF8740@kernel.org> References: <20160715210836.GB19522@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160715210836.GB19522@mwanda> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Jul 16, 2016 at 12:08:36AM +0300, Dan Carpenter escreveu: > info.e_machine is a uint16_t so m is never less than zero. It looks > like this was maybe left over code from earlier versions so I've just > removed it. Yeah, it sure looks like that, applying, thanks, - Arnaldo > Signed-off-by: Dan Carpenter > > diff --git a/tools/perf/jvmti/jvmti_agent.c b/tools/perf/jvmti/jvmti_agent.c > index 91bf333..55daeff 100644 > --- a/tools/perf/jvmti/jvmti_agent.c > +++ b/tools/perf/jvmti/jvmti_agent.c > @@ -59,7 +59,6 @@ static int get_e_machine(struct jitheader *hdr) > ssize_t sret; > char id[16]; > int fd, ret = -1; > - int m = -1; > struct { > uint16_t e_type; > uint16_t e_machine; > @@ -81,11 +80,7 @@ static int get_e_machine(struct jitheader *hdr) > if (sret != sizeof(info)) > goto error; > > - m = info.e_machine; > - if (m < 0) > - m = 0; /* ELF EM_NONE */ > - > - hdr->elf_mach = m; > + hdr->elf_mach = info.e_machine; > ret = 0; > error: > close(fd);