From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbcGQFG1 (ORCPT ); Sun, 17 Jul 2016 01:06:27 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:45246 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbcGQFGZ (ORCPT ); Sun, 17 Jul 2016 01:06:25 -0400 Date: Sat, 16 Jul 2016 22:06:23 -0700 (PDT) Message-Id: <20160716.220623.411789986162601008.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, mans@mansr.com, sf84@laposte.net, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: nb8800: Fix SKB leak in nb8800_receive() From: David Miller In-Reply-To: <1468626084-31618-1-git-send-email-f.fainelli@gmail.com> References: <1468626084-31618-1-git-send-email-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 16 Jul 2016 22:06:24 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Fri, 15 Jul 2016 16:41:16 -0700 > In case nb8800_receive() fails to allocate a fragment, we would leak the > SKB freshly allocated and just return, instead, free it. > > Reported-by: coverity (CID 1341750) > Signed-off-by: Florian Fainelli Applied.