From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751926AbcGPQPj (ORCPT ); Sat, 16 Jul 2016 12:15:39 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:43954 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbcGPQPh (ORCPT ); Sat, 16 Jul 2016 12:15:37 -0400 Date: Sat, 16 Jul 2016 18:15:28 +0200 From: Andrew Lunn To: Jamie Lentin Cc: Jason Cooper , Sebastian Hesselbarth , Gregory Clement , Imre Kaloz , Florian Fainelli , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v0 04/10] arm: orion5x: Generalise mv88f5181l pinctrl support for 88f5181 Message-ID: <20160716161528.GE1777@lunn.ch> References: <1468679348-10522-1-git-send-email-jm@lentin.co.uk> <1468679348-10522-5-git-send-email-jm@lentin.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468679348-10522-5-git-send-email-jm@lentin.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 16, 2016 at 03:29:02PM +0100, Jamie Lentin wrote: > As far as I'm aware the mv88f5181-b1 and mv88f5181l are the same at the > pinctrl level, so re-use the definitions for both. Good, you add a new compatibile string. So it if turns out they are not identical, we can fix it later without causing problems. Reviewed-by: Andrew Lunn Andrew