From: Rob Herring <robh@kernel.org>
To: Andrey Pronin <apronin@chromium.org>
Cc: "Jarkko Sakkinen" <jarkko.sakkinen@linux.intel.com>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Marcel Selhorst" <tpmdd@selhorst.net>,
"Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
groeck@chromium.org, smbarber@chromium.org,
dianders@chromium.org, devicetree@vger.kernel.org,
" Pawel Moll" <pawel.moll@arm.com>,
" Mark Rutland" <mark.rutland@arm.com>,
" Ian Campbell" <ijc+devicetree@hellion.org.uk>,
" Kumar Gala" <galak@codeaurora.org>
Subject: Re: [PATCH 1/2] tpm: devicetree: document properties for cr50
Date: Sun, 17 Jul 2016 08:28:01 -0500 [thread overview]
Message-ID: <20160717132801.GA5527@rob-hp-laptop> (raw)
In-Reply-To: <1468549218-19215-2-git-send-email-apronin@chromium.org>
On Thu, Jul 14, 2016 at 07:20:17PM -0700, Andrey Pronin wrote:
> Add TPM2.0-compatible interface to Cr50. Document its properties
> in devicetree.
>
> Signed-off-by: Andrey Pronin <apronin@chromium.org>
> ---
> .../devicetree/bindings/security/tpm/cr50_spi.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/security/tpm/cr50_spi.txt
>
> diff --git a/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt b/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt
> new file mode 100644
> index 0000000..1b05e51
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/security/tpm/cr50_spi.txt
> @@ -0,0 +1,30 @@
> +* Cr50 Chip on SPI.
> +
> +TCG PTP FIFO Compliant Interface to Cr50 on SPI bus.
> +
> +Required properties:
> +- compatible: Should be "google,cr50_spi".
I agree with dropping '_spi'. The interface is defined by the parent
device.
> +- spi-max-frequency: Maximum SPI frequency.
> +
> +Optional properties:
> +- access-delay-msec: Required delay between subsequent transactions on SPI.
There may be a standard property for this...
> +- sleep-delay-msec: Time after the last SPI activity, after which the chip
> + may go to sleep.
> +- wake-start-delay-msec: Time after initiating wake up before the chip is
> + ready to accept commands over SPI.
Use the standard unit '-ms' instead of '-msec'.
Do these times really vary much and need to be in DT?
next prev parent reply other threads:[~2016-07-17 13:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 2:20 [PATCH 0/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-15 2:20 ` [PATCH 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-15 4:05 ` Guenter Roeck
2016-07-15 17:31 ` Andrey Pronin
2016-07-15 18:28 ` Guenter Roeck
2016-07-17 13:28 ` Rob Herring [this message]
2016-07-15 2:20 ` [PATCH 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-15 3:32 ` Jason Gunthorpe
2016-07-15 3:44 ` Andrey Pronin
2016-07-19 12:55 ` Jarkko Sakkinen
2016-07-20 0:24 ` Andrey Pronin
2016-07-20 17:03 ` Jason Gunthorpe
2016-07-21 18:10 ` Andrey Pronin
2016-07-21 21:00 ` Jason Gunthorpe
2016-07-15 2:28 ` [PATCH 0/2] " Peter Huewe
2016-07-15 2:50 ` Andrey Pronin
2016-07-15 3:28 ` Jason Gunthorpe
2016-07-15 17:15 ` Andrey Pronin
2016-07-19 12:56 ` Jarkko Sakkinen
2016-07-20 3:41 ` [PATCH v2 " Andrey Pronin
2016-07-20 3:41 ` [PATCH v2 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-20 19:03 ` Rob Herring
2016-07-20 19:49 ` Andrey Pronin
2016-07-20 19:54 ` Jason Gunthorpe
2016-07-27 21:02 ` Andrey Pronin
2016-07-21 21:03 ` Rob Herring
2016-07-27 21:00 ` Andrey Pronin
2016-07-20 3:41 ` [PATCH v2 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-25 17:09 ` Aw: [PATCH v2 0/2] " Peter Huewe
2016-07-27 21:12 ` Andrey Pronin
2016-07-28 4:25 ` [PATCH v3 " Andrey Pronin
2016-07-28 4:25 ` [PATCH v3 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-28 4:25 ` [PATCH v3 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-07-28 23:01 ` Dmitry Torokhov
2016-07-28 23:17 ` Jason Gunthorpe
2016-07-29 3:01 ` Andrey Pronin
2016-07-29 1:55 ` [PATCH v4 0/2] " Andrey Pronin
2016-07-29 1:55 ` [PATCH v4 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin
2016-07-29 17:27 ` Jason Gunthorpe
2016-07-29 21:42 ` Rob Herring
2016-08-09 10:08 ` Jarkko Sakkinen
2016-07-29 1:55 ` [PATCH v4 2/2] tpm: add driver for cr50 on SPI Andrey Pronin
2016-08-09 10:20 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160717132801.GA5527@rob-hp-laptop \
--to=robh@kernel.org \
--cc=apronin@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=groeck@chromium.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=peterhuewe@gmx.de \
--cc=smbarber@chromium.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).