From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: <linux-clk@vger.kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
<devicetree@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
<linux-kernel@vger.kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property
Date: Sun, 17 Jul 2016 09:11:10 -0700 [thread overview]
Message-ID: <20160717161110.GY3847@xsjsorenbubuntu> (raw)
In-Reply-To: <1468682123-1434-1-git-send-email-yamada.masahiro@socionext.com>
On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote:
> The "clock-output-names" property is useful for generic clock
> providers such as fixed-clock, fixed-factor-clock, etc.
>
> On the other hand, it should not be used for really SoC-specific
> clock providers like this one. As you see in "enum zynq_clk" in
> this driver, it is written as if it already knows all the clock
> names. Besides, this is instantiated only once, so no clock name
> conflict would happen even if the clock names are hard-coded in the
> driver.
>
> The device tree (arch/arm/boot/dts/zynq-7000.dtsi) will be fixed
> later.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
IIRC, this was the only way to allow circular clock routing. E.g. there
are use-cases that route an FCLK back into the PS to use it as input for
the GEM. With the introduction of deferred probing this might all be
possible now but it would be good to verify that this kind of circular
clock routing still works with this change.
Sören
next prev parent reply other threads:[~2016-07-17 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 15:15 [PATCH] clk: zynq: avoid retrieving clock names from DT property Masahiro Yamada
2016-07-17 16:11 ` Sören Brinkmann [this message]
2016-07-18 17:22 ` Sören Brinkmann
2016-07-17 20:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160717161110.GY3847@xsjsorenbubuntu \
--to=soren.brinkmann@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).