From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751287AbcGQStu (ORCPT ); Sun, 17 Jul 2016 14:49:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42251 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbcGQStr (ORCPT ); Sun, 17 Jul 2016 14:49:47 -0400 Date: Sun, 17 Jul 2016 20:49:38 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , David Ahern , Jiri Olsa , Namhyung Kim , Wang Nan , Clark Williams , Mauro Carvalho Chehab , Arjan van de Ven , Alexandra Yates , Nivedita Swaminathan Subject: Re: [PATCH 29/66] tools lib traceevent: Use str_error_r() Message-ID: <20160717184938.GA4996@krava> References: <20160712191108.63d23fae@gandalf.local.home> <20160712231424.GA26691@kernel.org> <20160712192519.601b1fae@gandalf.local.home> <20160712233218.GB26691@kernel.org> <20160713083001.1dfa2b0e@gandalf.local.home> <20160713135125.GA27879@kernel.org> <20160713151700.3cc8f65e@gandalf.local.home> <20160713200148.GA6961@kernel.org> <20160713212550.1d5a192c@gandalf.local.home> <20160714013909.GG6961@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160714013909.GG6961@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sun, 17 Jul 2016 18:49:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2016 at 10:39:09PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jul 13, 2016 at 09:25:50PM -0400, Steven Rostedt escreveu: > > On Wed, 13 Jul 2016 17:01:48 -0300 Arnaldo Carvalho de Melo wrote: > > > > perf, trace-cmd/kernelshark, powertop and ras-daemon > > > > > > Cool, so this is all just about tools/lib/traceevent/ after all, sure, > > > go ahead, you're the "external source" after all :-) > > > > Great! We're on the same page then ;-) > > It took a while, now it seems so :-) heya, after discussing this with Arnaldo I checked the possibility of adding traceevent as a fedora kernel rpm subpackage.. and to my surprise fedora already has following rpms: (see attached rpm -ql output for list of their files) kernel-tools kernel-tools-libs kernel-tools-libs-devel I wonder we could solve all this by adding traceevent lib into kernel-libs and kernel-libs-devel packages. I tried and with easy change to fedora kernel.spec made following rpm: --- [jolsa@krava fedora]$ rpm -ql -p /home/jolsa/rpmbuild/RPMS/x86_64/kernel-tools-libs-devel-4.7.0-0.rc7.git3.1.fc22.x86_64.rpm /usr/include/cpufreq.h /usr/lib64/libcpupower.so /usr/lib64/libtraceevent.a /usr/lib64/libtraceevent.so /usr/lib64/traceevent/plugins/plugin_cfg80211.so /usr/lib64/traceevent/plugins/plugin_function.so /usr/lib64/traceevent/plugins/plugin_hrtimer.so /usr/lib64/traceevent/plugins/plugin_jbd2.so /usr/lib64/traceevent/plugins/plugin_kmem.so /usr/lib64/traceevent/plugins/plugin_kvm.so /usr/lib64/traceevent/plugins/plugin_mac80211.so /usr/lib64/traceevent/plugins/plugin_sched_switch.so /usr/lib64/traceevent/plugins/plugin_scsi.so /usr/lib64/traceevent/plugins/plugin_xen.so --- we'll need to make some enhancements to install targets to provide header files and *.so.VERSION files.. and some other minor things the kernel-tools-libs file could looks like (haven't made this one): --- [jolsa@krava fedora]$ rpm -ql kernel-tools-libs /usr/lib64/libcpupower.so.0 /usr/lib64/libcpupower.so.0.0.0 /usr/lib64/libtraceevent.so.0 /usr/lib64/libtraceevent.so.0.0.0 --- I haven't checked other distro's kernel packages but I guess it'll be similar this way we export traceevent lib for other users and its source stays in the kernel thoughts? ;-) jirka --- [jolsa@krava fedora]$ rpm -qa kernel-tools kernel-tools-4.4.14-200.fc22.x86_64 [jolsa@krava fedora]$ rpm -ql kernel-tools /etc/sysconfig/cpupower /usr/bin/centrino-decode /usr/bin/cpupower /usr/bin/powernow-k8-decode /usr/bin/tmon /usr/bin/turbostat /usr/bin/x86_energy_perf_policy /usr/lib/systemd/system/cpupower.service /usr/share/locale/cs/LC_MESSAGES/cpupower.mo /usr/share/locale/de/LC_MESSAGES/cpupower.mo /usr/share/locale/fr/LC_MESSAGES/cpupower.mo /usr/share/locale/it/LC_MESSAGES/cpupower.mo /usr/share/locale/pt/LC_MESSAGES/cpupower.mo /usr/share/man/man1/cpupower-frequency-info.1.gz /usr/share/man/man1/cpupower-frequency-set.1.gz /usr/share/man/man1/cpupower-idle-info.1.gz /usr/share/man/man1/cpupower-idle-set.1.gz /usr/share/man/man1/cpupower-info.1.gz /usr/share/man/man1/cpupower-monitor.1.gz /usr/share/man/man1/cpupower-set.1.gz /usr/share/man/man1/cpupower.1.gz /usr/share/man/man8/turbostat.8.gz /usr/share/man/man8/x86_energy_perf_policy.8.gz [jolsa@krava fedora]$ rpm -ql kernel-tools-libs /usr/lib64/libcpupower.so.0 /usr/lib64/libcpupower.so.0.0.0 [jolsa@krava fedora]$ rpm -ql kernel-tools-libs-devel /usr/include/cpufreq.h /usr/lib64/libcpupower.so [jolsa@krava fedora]$