From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbcGQU0J (ORCPT ); Sun, 17 Jul 2016 16:26:09 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34863 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138AbcGQU0H (ORCPT ); Sun, 17 Jul 2016 16:26:07 -0400 Date: Sun, 17 Jul 2016 15:26:04 -0500 From: Rob Herring To: Shuah Khan Cc: pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, kgene@kernel.org, k.kozlowski@samsung.com, mchehab@osg.samsung.com, andrzej.p@samsung.com, j.anaszewski@samsung.com, hans.verkuil@cisco.com, javier@osg.samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: Doc add missing documentation for samsung,exynos4212-jpeg Message-ID: <20160717202522.GA8777@rob-hp-laptop> References: <1468620627-9750-1-git-send-email-shuahkh@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468620627-9750-1-git-send-email-shuahkh@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2016 at 04:10:27PM -0600, Shuah Khan wrote: > Add add missing documentation for samsung,exynos4212-jpeg codec, > reorder entries to improve readability and make it easier to add > new entries. > > samsung,exynos4212-jpeg and samsung,exynos4210-jpeg are identical, > hence add samsung,exynos4212-jpeg as deprecated in the documentation. > > Signed-off-by: Shuah Khan > --- > > Changes since v1: > - Added samsung,exynos4212-jpeg as deprecated > > Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > index 38941db..c5399e7 100644 > --- a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > +++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > @@ -3,9 +3,11 @@ Samsung S5P/EXYNOS SoC series JPEG codec > Required properties: > > - compatible : should be one of: > - "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg", > - "samsung,exynos3250-jpeg", "samsung,exynos5420-jpeg", > + "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg", > + "samsung,exynos4210-jpeg", "samsung,exynos5420-jpeg", > "samsung,exynos5433-jpeg"; > + > + (Deprecated: "samsung,exynos4212-jpeg"). Since you are reformatting, one compatible per line (unless multiple apply) is preferred. > - reg : address and length of the JPEG codec IP register set; > - interrupts : specifies the JPEG codec IP interrupt; > - clock-names : should contain: > -- > 2.7.4 >